Can't start or stop CHE instances

[torpede]

Can't start or stop CHE instances

[petrjanikac]

I checked what parameters LCS currently sends on start/stop and compared to 2LCS and there is an extra parameter EnvironmentId. I did a quick test and after adding the EnvironmentId parameter, the start/stop action is already performed correctly.

internal async Task<bool> StartStopDeployment(CloudHostedInstance instance, string action)
{
    var parameters = $"{action}=&ActivityId={instance.ActivityId}&ProductName={WebUtility.UrlEncode(instance.ProductName)}&TopologyName={instance.TopologyName}&TopologyInstanceId={instance.InstanceId}&AzureSubscriptionId={instance.AzureSubscriptionId}&EnvironmentGroup=0&EnvironmentId={instance.EnvironmentId}";
    using (_stringContent = new StringContent(parameters, Encoding.UTF8, "application/x-www-form-urlencoded"))
    {
        SetRequestVerificationToken($"{LcsUrl}/V2");
        var result = await _httpClient.PostAsync($"{LcsUrl}/DeploymentPortal/StartStopDeployment/{LcsProjectId}", _stringContent);
        result.EnsureSuccessStatusCode();
        var responseBody = result.Content.ReadAsStringAsync().Result;
        return responseBody == "true";
    }
}

[fandas-eu]

We observe the same behavior :-(

[FH-Inway]

Thanks for reporting, I can reproduce a similar issue with version 0.43.0. For me, when trying to stop a CHE, I first get a dialog "Please login to LCS again. Your cookie probably expired". After I confirm with OK, the blank login form appears for a few seconds, then vanishes and the "Choose LCS project" form is shown instead.
I also tried logging out and in again, but that did not resolve the issue.

The error occurs here (line 713):

2LCS/2LCS/HttpClientHelper.cs

Lines 706 to 717 in cfe5671

	internal async Task<bool> StartStopDeployment(CloudHostedInstance instance, string action)
	{
	var parameters = $"{action}=&ActivityId={instance.ActivityId}&ProductName={WebUtility.UrlEncode(instance.ProductName)}&TopologyName={instance.TopologyName}&TopologyInstanceId={instance.InstanceId}&AzureSubscriptionId={instance.AzureSubscriptionId}&EnvironmentGroup=0";
	using (_stringContent = new StringContent(parameters, Encoding.UTF8, "application/x-www-form-urlencoded"))
	{
	SetRequestVerificationToken($"{LcsUrl}/V2");
	var result = await _httpClient.PostAsync($"{LcsUrl}/DeploymentPortal/StartStopDeployment/{LcsProjectId}", _stringContent);
	result.EnsureSuccessStatusCode();
	var responseBody = result.Content.ReadAsStringAsync().Result;
	return responseBody == "true";
	}
	}

What happens is that the call to the LCS API returns a 500 status code (internal server error). /DeploymentPortal/StartStopDeployment is not part of the official LCS API to start/stop environments. This part of 2LCS was probably written before that API was available. It is also possible that the official API would not work with the 2LCS approach of authentication. My guess would be that Microsoft made changes to the /DeploymentPortal/StartStopDeployment part of the API.

@TomekMelissa This is a bit out of my wheel house. Do you know if /DeploymentPortal/StartStopDeployment can still be used and what changes we would have to make?

[FH-Inway]

Awesome, thank you @petrjanikac . A new version with the fix is available in https://github.com/microsoft/2LCS/releases/tag/v.0.44.0.

[torpede]

Awesome indeed, thank you @petrjanikac for a fast fix. Verified that it works :)