Giter Site home page Giter Site logo

Comments (1)

bobbinth avatar bobbinth commented on July 29, 2024

I think we can take it a bit further in terms making deltas more "specialized". For example, AccountVaultDelta could look something like this:

pub struct AccountVaultDelta {
    fungible: BTreeMap<AccountId, i64>,
    non_fungible: BTreeMap<Digest, bool>,
}

I would also probably update serialization to work roughly as follows:

  • First serialize fungible asset updates as (account_id, amount_delta) tuples.
  • Then serialize added non-fungible assets.
  • Then serialize removed non-fungible assets.

For AccountStorageDelta, I think it still may make sense to keep the simple slot updates separate from map updates. Specifically, it could look something like this:

pub struct AccountStorageDelta {
    slots: BTreeMap<u8, Word>,
    maps: BTreeMap<u8, StorageMapDelta>,
}

pub struct StorageMapDelta(BTreeMap<Digest, Word>);

For serialization, we could probably still keep something that is roughly similar to the current structure:

  • First serialize updated slots (i.e., where the new slot value is non-empty word) as (slot_index, slot_value) tuples.
  • Then serialize cleared slots (for this we only need to serialize slot indexes).
  • Then serialize storage map deltas as:
    • First updated leaves as a list of (key, value) tuples.
    • Then serialize cleared leaves as a list of just keys.

from miden-base.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.