MetaMask warning with `web3.eth.sign`

[0xproject]

MetaMask warning with `web3.eth.sign`

[fabioberger]

Hi Brandon,

Thanks for bringing this up. This is something we are aware of, but have decided not to change it to the web3.personal.sign implementation since it currently only supporting signing ASCII strings and would display as follows:

This is hardly an improvement over the scary message where the user can at least see the actual orderHash they are signing.

We are drafting an EIP with a proposed solution that will solve this problem. Our solution follows that discussed in these comments: ethereum/EIPs#683 (comment) AND ethereum/EIPs#683 (comment)

We want a version of web3.eth.sign that will allow signers to display the actual data the user is signing the hash of so they can actually verify the specifics of what they are signing.

[fabioberger]

Our EIP has been received extremely well by the broader Ethereum ecosystem and we are working on getting it adopted by all major client nodes and signers.

EIP: ethereum/EIPs#712

[arisAlexis]

actually eth.personal.sign works fine with Metamask, thanks

[rawadrifai]

Metamask now hangs indefinitely when using web3.eth.sign.
Is this what's happening with 0x?

[miketeix]

Yeah same :(

[rawadrifai]

Found the solution for it! gotta use the web3.eth.sendAsync method. Metamask still doesn't support web3.eth.personal.sign. This is what we did for Taurus.io beta, which is relatively similar to 0x's concept except that it does derivatives, so contract HAVE to live on blockchain and executed later.

Web3 and Metamask just do not go well together :/

[fabioberger]

Hm, it's not hanging for me... Just tested this on Portal. Could you guys provide some repro steps?

[arisAlexis]

I wish this would be opened. signing in my dapp backend server with Metamask is the obvious way otherwise you need a username and password on top. Metamask just hangs (and also displays a scary warning)

[fabioberger]

@arisAlexis do you have a repro you could share?