With 0x.js v0.27.1 Webpack fails to minify `./node_modules/ethereum-address/index.js:3` when running a build

[0xproject]

With 0x.js v0.27.1 Webpack fails to minify `./node_modules/ethereum-address/index.js:3` when running a build

[MarcZenn]

I believe I found a way around this. Please see ccxt/ccxt#299.

It seems that because there isn't a transpiled version of ./node_modules/ethereum-address/index.js You can use the following hack to circumvent the issue.

      {
        test: require.resolve("ethereum-address"),
        loader: require.resolve("babel-loader"),
        options: { compact: true }
      },

This definitely is NOT the way to solve the problem but for now it can get you by.

[fabioberger]

Yep, we can remove this dependency and re-implement it ourselves. We will do so once: #253 gets merged since isAdddress would ideally live in the utils subpackage.

[davidqhr]

Please remove this dependency.

Now, I have to compile this file in the ci process.

node_modules/.bin/babel node_modules/ethereum-address/index.js > node_modules/ethereum-address/index.js

[davidqhr]

@LogvinovLeon

I found ethereum-address is still a dependency of @0xproject/assert

https://github.com/0xProject/0x.js/blob/a6f97181310c9acba176b2a28ffba1ca7d53727d/packages/assert/package.json#L42

And @0xproject/assert is a dependency of [email protected]

https://github.com/0xProject/0x.js/blob/a6f97181310c9acba176b2a28ffba1ca7d53727d/packages/0x.js/package.json#L89