Giter Site home page Giter Site logo

Comments (2)

davidqhr avatar davidqhr commented on May 24, 2024

I'm here to answer my own question.

This is a bug in my code, not 0x.

I used a wrong function to get the buffer of a vrs
https://github.com/MetaMask/provider-engine/blob/176cafc0f8212b83b5327b63b80a6bb43909ee68/subproviders/hooked-wallet-ethtx.js#L69

The correct one
https://github.com/MetaMask/eth-sig-util/blob/master/index.js#L6

from 0x-monorepo.

davidqhr avatar davidqhr commented on May 24, 2024

Add a error case

{ r: <Buffer 6b cd 56 90 c9 eb 90 e9 78 94 d1 dd 89 40 42 32 10 cf 02 35 f7 c0 62 a7 d5 a9 b8 0d fc b7 06 b6>,
  s: <Buffer 00 12 0c c5 f1 9b ec 47 76 d8 cf aa 12 81 7c f3 42 96 f9 eb 82 b0 87 72 a8 86 74 24 56 93 30 e1>,
  v: 28 } 

result 1

0x6bcd5690c9eb90e97894d1dd8940423210cf0235f7c062a7d5a9b80dfcb706b6120cc5f19bec4776d8cfaa12817cf34296f9eb82b08772a8867424569330e11c

result 2

0x6bcd5690c9eb90e97894d1dd8940423210cf0235f7c062a7d5a9b80dfcb706b600120cc5f19bec4776d8cfaa12817cf34296f9eb82b08772a8867424569330e11c

from 0x-monorepo.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.