Giter Site home page Giter Site logo

Comments (6)

inumanag avatar inumanag commented on July 19, 2024

Hi @lonny1999,

This is a minor variant that does not define *3 in this case. It is only listed in the minor detection step (minor variants are usually listed in the output file only, not on the screen).

What is the output you get (both -o and on-screen output)? I can take a look to see if it is really there.

from aldy.

lonny1999 avatar lonny1999 commented on July 19, 2024

Thank you for your prompt reply! @inumanag

The output (both -o and the on-screen output) do not show the minor variant. Other variants that do define *3 are not in my input, only the [23936, A>G, rs7088784] variant is there.

Please find attached screenshots of my output and snippets of my input file on which the variants detected by Aldy are present and the one not detected in blue.

(I'm sorry for my late reply, I had to check what data I could share here)
output_aldy
variants_1
variants_2
variants_notdetected

from aldy.

inumanag avatar inumanag commented on July 19, 2024

Seems that you do not have all major *3 variants: rs4986893 and rs144036596 are not present in the output. That means that *3 is not present in the sample (it is only present if all functional mutations are there).

Since rs7088784 is minor and associated with *3 in the database, Aldy won't report it if it cannot find *3 at all (minor mutations are only reported if their parent allele is present; major mutations, on the other hand, are always included).

You can force-tweak this by adding rs7088784 to the *1 section in the YML file; Aldy will be able to report it in that case.

I will see if I can fix this in the next version so that manual tweaks are no longer necessary.

from aldy.

lonny1999 avatar lonny1999 commented on July 19, 2024

Thank you very much for the clear explanation and advice! Very logical for Aldy to work that way. A tweak for this in the next version would be really convenient indeed!

In the meantime (after some more genotype calling with Aldy) I noticed that, when the variants of a sample do not completely match, this is reported by '+rsnumber' in the output behind the active allele. Is it indeed true that this '+rsnumber' is always/by default added to the active starallele? (so in case of *1/*2 it's added to *1 and in case of *17/*2 to *17?)

Besides, I got a little bit confused by the *17 section in the YML file of cyp2c19 since there are four variants there, while in PharmVar there are only three. When following the cited resource link, this also brings me to the PharmVar page only displaying three variants for *17.001 (in GRCh38). After looking more into this, I found out that rs11188072 is not in the current PharmVar, but is present in the archived cyp alleles and is also a variant according to literature. Anyway, I thought I would mention it here :)

from aldy.

inumanag avatar inumanag commented on July 19, 2024

"+rs" part is only added to major star alleles in the presence of another functional SNP that is not part of the definition. e.g. 17+rsXY/2 is basically *17 with additional rsXY and *2. Note that in the current version, +rs can be added equally likely to both 17 and 2 (in the Aldy 4 that is currently in beta we actually try to phase these cases, however the phasing only works if you have long enough reads to cover the SNP distance). So you can treat such calls as "17/2 and some functional rsXY that can belong to either allele" in Aldy 3.

Thanks for the report. I am planning to refresh PharmVar definitions these days anyways :)

from aldy.

inumanag avatar inumanag commented on July 19, 2024

PharmVar is refreshed in #31. Closing this issue—please reopen if still experiencing the problems.

from aldy.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.