Comments (3)
Follow-up to the above: simply changing the existing attribute types from int
to integer
does in fact prevent the warnings, but is not enough, and would require additional changes to the plugin's codebase, as it would not be compatible with the current version of the plugin, nor backwards-compatible with pre-existing Brightcove video blocks in the Gutenberg editor, that were added in older versions of WordPress. Whereas, changing the attribute types to string
seems to be fully compatible so far.
https://developer.wordpress.org/block-editor/developers/block-api/block-attributes/
from brightcove-video-connect.
This issue appears to persist in WordPress 5.6
from brightcove-video-connect.
A possible workaround is to change these attributes using the filter register_block_type_args:
add_filter(
'register_block_type_args',
function ( $args, $block_type ) {
if ( 'bc/brightcove' === $block_type ) {
$args['attributes']['account_id']['type'] = 'string';
$args['attributes']['video_id']['type'] = 'string';
$args['attributes']['playlist_id']['type'] = 'string';
$args['attributes']['video_ids']['type'] = 'string';
}
return $args;
},
10,
2
);
from brightcove-video-connect.
Related Issues (20)
- wp.components.IconButton is deprecated since version 5.4 and will be removed in version 6.2. Please use wp.components.Button instead.
- Using custom components as toolbar controls is deprecated since version 5.6. Please use ToolbarItem, ToolbarButton or ToolbarDropdownMenu components instead
- Interactivity player should not be globally available.
- Help notices being displayed more than once HOT 1
- Videos page and navigation HOT 1
- Move playlists notice outside the controls bar HOT 1
- Playlists: Empty "Created At:" and "Updated At:" HOT 1
- Support special characters: Text sanitization is too extreme
- Search box is not aligned. HOT 1
- Deprecated warnings on PHP 8.2 HOT 1
- Warning message: 'Undefined array key "sub_type"'
- Error message remains on the screen even after the new AJAX call runs successfully.
- "Add New Label" form shows "Label added" notice even when the form fields are empty
- Notice: Only variables should be passed by reference
- [Release] 2.8.4
- Register Brightcove block within media block category, not text.
- Failing experiences REST API request HOT 1
- [Release] 2.8.5
- Brightcove Video Block requires 'Block Recovery' due to misnamed attribute 'languageDetection' HOT 3
- Brightcove block not working in custom post type
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from brightcove-video-connect.