Giter Site home page Giter Site logo

Comments (3)

toufic-m avatar toufic-m commented on July 17, 2024

Follow-up to the above: simply changing the existing attribute types from int to integer does in fact prevent the warnings, but is not enough, and would require additional changes to the plugin's codebase, as it would not be compatible with the current version of the plugin, nor backwards-compatible with pre-existing Brightcove video blocks in the Gutenberg editor, that were added in older versions of WordPress. Whereas, changing the attribute types to string seems to be fully compatible so far.

https://developer.wordpress.org/block-editor/developers/block-api/block-attributes/

from brightcove-video-connect.

mollfrey avatar mollfrey commented on July 17, 2024

This issue appears to persist in WordPress 5.6

from brightcove-video-connect.

Rahmon avatar Rahmon commented on July 17, 2024

A possible workaround is to change these attributes using the filter register_block_type_args:

add_filter(
	'register_block_type_args',
	function ( $args, $block_type ) {
		if ( 'bc/brightcove' === $block_type ) {
			$args['attributes']['account_id']['type']  = 'string';
			$args['attributes']['video_id']['type']    = 'string';
			$args['attributes']['playlist_id']['type'] = 'string';
			$args['attributes']['video_ids']['type']   = 'string';
		}

		return $args;
	},
	10,
	2
);

from brightcove-video-connect.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.