Comments (6)
I've added a block setting where you can paste in any valid skin URL:
These URLs come from going to https://skins.webamp.org/ and then clicking on any skin. You then copy the resulting URL and paste that into this new field.
This is then parsed on the FE to load the correct skin:
Not exactly sure if this is the approach we want to go with or not, so look at this more of a proof of concept that we can change if desired.
from retro-winamp-block.
@dkotter that's awesome, nice work! The next question will be how to potentially load a custom skin if we're unable to get the one that @melchoyce is helping to create published on the skins.webamp.org site?
from retro-winamp-block.
Couple options that come to mind:
- Right now if no skin URL is entered, we just load whatever default skin comes with the player. We could make the custom skin the default instead and bundle that skin with the plugin
- If we don't want it to be the default, we could still bundle the skin but then have a toggle to turn that skin on (and probably hide the skin URL input)
- We could go fancier and have an upload field allowing any custom skin file to be used. We would have to add support for .wsz files to WordPress but this would allow any custom skin to be used. Not sure it's worth the effort and also doesn't solve how other people will download this custom skin to use in the first place
from retro-winamp-block.
It looks like we may be able to submit our custom skin via https://skins.webamp.org/upload/ and then link to that similarly to linking to other skins in the library.
from retro-winamp-block.
We could have some skins as options in a single select at launch with the basic winamp skin as default, but figure out a graceful UX way to allow folks to select other skins in the library. Though a simple URL field also generally achieves that as well.
from retro-winamp-block.
I'd like to see us have a small set of skins easily selectable, either as a dropdown with their names displayed or (ideally better) thumbnails of each selectable, and then an advanced option to enter the skin URL (current functionality). The subset of default skins would be the 4 in the first list in the description of #1 (with ideally a custom skin crafted in that issue to be added later). Obviously if someone is passionate enough about another skin(s) being a default option then I'm open to that as well.
from retro-winamp-block.
Related Issues (20)
- Release version 1.0.1
- Test against WordPress 5.9 HOT 2
- page loading at the bottom HOT 7
- Add PHP8 Compatibility testing workflow
- Test against WordPress 6.0
- add support for Milkdrop visualizations HOT 1
- Console error in the Editor and FE when previewing the Winamp Player HOT 2
- Setup Cypress for E2E testing
- Add phpcs config file to project.
- Release version 1.1.0
- Bump WordPress and PHP minimums
- The plugin hasn't been tested with the latest version of WordPress
- Added "Build release zip" GitHub Action.
- Update Support Level from Active to Stable HOT 1
- preview doesn't work anymore
- Release 1.2.0
- Improve the content blocking view of Winamp block
- Unable to save the post in WordPress 5.8 HOT 2
- The plugin hasn't been tested with the latest version of WordPress
- Release 1.3.0
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from retro-winamp-block.