Giter Site home page Giter Site logo

Mixing Tabs and Spaces about wp-component-library HOT 8 CLOSED

10up avatar 10up commented on September 13, 2024
Mixing Tabs and Spaces

from wp-component-library.

Comments (8)

jonbellah avatar jonbellah commented on September 13, 2024 1

Yep, looks like we're good. I'm working on some updates elsewhere and will update the spacing on the CSS files before merging.

from wp-component-library.

jonbellah avatar jonbellah commented on September 13, 2024

Beat me to the punch. Agree with this entirely. It's also part of the WordPress Coding Standards.

Should be a fairly easy PR for someone.

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

I don't mind going through and converting any spaces I find into tabs. Would you prefer separate PRs for each file where this happens or one bulk PR for all the space to tab changes?

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

In the process of working on PRs based on file type to make PRs a bit more digestible when I submit them. Starting with the HTML whitespace to tab indentation. Then eventually JS/Sass if I'm able - each separate PRs. I'll only be focusing on the starting indentation. Any other spacing/line breaks within the code will be considered "cleanup" and therefore be future PRs for anyone else that wants to tackle them. 👍

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

PR submitted for components.html files that were using whitespace indentation: #41

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

PR submitted for component Sass files: #42

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

Submitted PR for JS files. I'd done the tabs component but since there was work done there since I last updated from gh-pages, I just took the gh-pages version. Will have to go back in there later. For now, the rest are in this PR.

#45

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

Updated the tabs component JS indentation. PR submitted and we're likely good to close this one out - unless anyone sees some areas we can adjust whitespace indentation to tabs?

#47

from wp-component-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.