Comments (8)
Yep, looks like we're good. I'm working on some updates elsewhere and will update the spacing on the CSS files before merging.
from wp-component-library.
Beat me to the punch. Agree with this entirely. It's also part of the WordPress Coding Standards.
Should be a fairly easy PR for someone.
from wp-component-library.
I don't mind going through and converting any spaces I find into tabs. Would you prefer separate PRs for each file where this happens or one bulk PR for all the space to tab changes?
from wp-component-library.
In the process of working on PRs based on file type to make PRs a bit more digestible when I submit them. Starting with the HTML whitespace to tab indentation. Then eventually JS/Sass if I'm able - each separate PRs. I'll only be focusing on the starting indentation. Any other spacing/line breaks within the code will be considered "cleanup" and therefore be future PRs for anyone else that wants to tackle them. 👍
from wp-component-library.
PR submitted for components.html files that were using whitespace indentation: #41
from wp-component-library.
PR submitted for component Sass files: #42
from wp-component-library.
Submitted PR for JS files. I'd done the tabs component but since there was work done there since I last updated from gh-pages, I just took the gh-pages version. Will have to go back in there later. For now, the rest are in this PR.
from wp-component-library.
Updated the tabs component JS indentation. PR submitted and we're likely good to close this one out - unless anyone sees some areas we can adjust whitespace indentation to tabs?
from wp-component-library.
Related Issues (20)
- [docs] Page Titles and Descriptions HOT 2
- [docs] Header Tags
- [docs] Response Codes
- [docs] Robots.txt
- New Component: Animation Library HOT 1
- Modal: Update modal documentation to recommend use of `<div>` over `<dialog>`
- Update Component: update component scaffolding HOT 2
- New Component: React Accordion
- New Component: React Tabs
- Update component: accordion (design)
- Update component: Tabs
- Update component: Navigation
- Officially vet custom select menu plugin for compliance
- Add <caption> elements to all documentation tables HOT 2
- New Component: Convert custom select into npm package HOT 2
- New Gutenberg: Content/Block Structure HOT 1
- New Component: Data visualization library HOT 1
- Investigate pulling component read me files directly into docs
- Investigate DuetDS date picker for accessibility compliance HOT 3
- A11y Upgrades - refer to Van11y
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from wp-component-library.