Giter Site home page Giter Site logo

Comments (5)

timwright12 avatar timwright12 commented on September 13, 2024

I would treat icons the same way we treat general imagery. If an icon is purely decorative, then yeah, aria-hidden the crap out of it; if it has meaning that needs to be communicated to the user, let the screen reader consuming and maybe even use an aria-label to help it announce better.

from wp-component-library.

jonbellah avatar jonbellah commented on September 13, 2024

Dig it. Mind submitting a PR if you've got some free time? (If not, no worries)

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

@jonbellah I should have some time today. :fingerscrossed: :-)

from wp-component-library.

RachelRVasquez avatar RachelRVasquez commented on September 13, 2024

PR submitted for the hamburger icon. #40

from wp-component-library.

timwright12 avatar timwright12 commented on September 13, 2024

This got merged a bit ago. Closing out.

from wp-component-library.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.