Giter Site home page Giter Site logo

Comments (5)

13rac1 avatar 13rac1 commented on May 27, 2024 2

After #26:
squirrel_after

from emojione-color-font.

13rac1 avatar 13rac1 commented on May 27, 2024

Thanks for reporting.

Interesting. I use SVGs from the Emoji One project as-is. I can reproduce it and narrowed it down to missing SVG fills on three of the paths in that file. It seems Firefox does the "regular" selected text color inversion only when the path fill is not set.

This is an issue with the Emoji One project: https://github.com/Ranks/emojione/blob/master/assets/svg/1f43f.svg

When those SVGs are updated I'll change it.

from emojione-color-font.

13rac1 avatar 13rac1 commented on May 27, 2024

@Happy-Ferret Ranks Inc. has declined to accept graphic updates for the Emoji One project. I'm re-opening this to fix the problem of the #000000 black selection inversion.

The correct procedure (in case someone wants to submit a PR):

  1. Move the original squirrel to assets/emojione-svg/disabled
  2. Copy to: assets/svg
  3. Fix the problem by adding the correct #3e4347 color, since it's what is used instead of black throughout the Emoji One project, to all three paths.
  4. Submit the PR. Close this issue and reference the emojione issue in the git commit message.

from emojione-color-font.

13rac1 avatar 13rac1 commented on May 27, 2024

Please close issues via PR. Details: https://github.com/blog/1506-closing-issues-via-pull-requests

from emojione-color-font.

13rac1 avatar 13rac1 commented on May 27, 2024

Screenshot of the problem for future reference:

squirrel_before

from emojione-color-font.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.