Comments (7)
We discussed yesterday that it wouldn't work because the DOM keeps being destroyed and reinserted.
from 18f.gsa.gov.
Can we remove the href attribute? I don't believe we need to link directly to anything. The sources are cited.
from 18f.gsa.gov.
Remove the href from what element?
from 18f.gsa.gov.
From the photo-credit
from 18f.gsa.gov.
Ah right. I like the ability to look at the source of the images, but we are attributing. Passing back to @quepol to make final decision on whether to remove the links.
from 18f.gsa.gov.
I know we discussed the DOM issue, but I swear it was working at some point during my testing. Alas...
I, too, make it a best practice to link, not just text attribute. Let's leave it for now.
from 18f.gsa.gov.
Resolved w/ that commit. Closing.
from 18f.gsa.gov.
Related Issues (20)
- Adjust positioning and aspect ratio of blog post banners
- replatform: missing section HOT 1
- replatform: missing id for headers (for anchors) HOT 6
- replatform: img alt has "undefined" (should be blank)
- replatform: title segments are swapped HOT 1
- replatform: missing aria-label HOT 3
- replatform: tag pages do not sort by last date
- replatform: redirect from team to author is not implemented HOT 5
- replatform: posts do not properly link to feed
- replatform: footnotes missing role attributes
- replatform: author page is missing tags HOT 1
- replatform: external links are not marked appropriately
- replatform: /contact is missing social media box HOT 1
- replatform: emails should not have external link? HOT 2
- https://18f.gsa.gov/our-work/federalist/ has the wrong template HOT 2
- BUG: Older blog post images sometimes have overlaid captions HOT 1
- BUG: Meta descriptions don't display on most pages HOT 1
- BUG: Related posts don't show up on new blog posts
- Remove CircleCI HOT 3
- Update illustrations to use 18F's open peeps adaptation
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 18f.gsa.gov.