Comments (3)
@rememberlenny this overall strategy seems fine / standard to me.
For me, it is easier to evaluate a strategy when I see it implemented. I noticed that the linked branch has ~250 commits and 22k changes.
Is there a reason we are putting so much work on one branch without doing PRs? Is that branch just for a demo we are going to throw away and rebuild later? If so, totally cool to continue down the path of putting it all on there without review. If not, I think we need to discuss the process moving forward.
tl;dr I'd love to review some code that implements the above strategy, ideally in the form of a small PR that I can review / QA in under 30 mins.
from c2.
@jessieay This point about PR review is really great.
Right now, the plan was to build a beta feature on production situations/DB. We were iterating quickly on the actual code design/implementation, so the small PR process didn't make sense.
We are still doing some major changes on the design end, which are not all "final". The next phase is to build out tests in the existing code.
What are your thoughts on the best way to properly have reviewable chunks at this point?
from c2.
Ahhhh ok so if we do want this merged in (aka - not thrown away), the branch as-is is def too large to review.
Like you said, we need to find a way to break it into smaller chunks. It's OK if we PR those small chunks against a non-master branch if it doesn't make sense to merge the smaller pieces into master (like with EMAIL redesign).
I am not very familiar with what exactly this branch contains so I don't have any suggestions for how to break it up off the top of my head.
As a rule of thumb, I try to keep PRs under 500 changes (additions + deletions) unless it is a large stylistic change that results in a noisy diff but is not complicated to read (eg: changing 1000 single quotes to double or something like that).
Let me know if you'd like to talk through some ideas on how to break it up. Happy to talk through it together!
from c2.
Related Issues (20)
- Onboarding for Robb HOT 6
- konacha / sprockets update HOT 1
- Onboarding Micah
- CVE-2016-6316 in rails HOT 1
- API isn't working HOT 3
- Date submitted bug HOT 1
- Blanket branding question
- Incorrect recurring interval value
- Incorrect Purchase Type Displayed
- Visual bug: new purch req form selector missing chevron
- Canceling a request doesn't cancel a request HOT 1
- Cookies are sent via HTTP instead of HTTPS HOT 3
- Add additional logging for ATO HOT 1
- Create user account for penetration testing
- Supervisor select box is extremely difficult to use
- Migrate email service off Mandrill
- The mail job is failing HOT 3
- Remove "micropurchase" from gsa18f options
- Remove references to cg-fake-uaa
- ?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from c2.