Giter Site home page Giter Site logo

Comments (7)

msecret avatar msecret commented on July 18, 2024

As a counter-point to this (I'm not against it just wanted to spur conversation), having a list like this could be confusing to people as the styleguide is filling the same space, although in a more extensive format. I would also question whether people would still find it useful with the styleguide there, or if it would just detract from the styleguide.

from frontend.

jeremiak avatar jeremiak commented on July 18, 2024

If this can be automatically generated from the style guide, then I'm all for it. If not, I'm against it.

This is the same information in the style guide, though I'd argue that the style guide is a bit more informative since it contains some rationales and background information. That being said, a quick digest might be helpful to some users but I don't think keeping three sources of information up to date would be a good idea (style guide, lint config file and then this digested list). Just my 💭s

from frontend.

maya avatar maya commented on July 18, 2024

The frontend coding guide includes recomendations that are not in the linter bc some things can't be codified. So I can't trace what in the coding guide is also in the linter.

from frontend.

msecret avatar msecret commented on July 18, 2024

I'd agree with Jeremia in that I don't want duplication, but agree with @maya that it might be helpful to know what aspects of the styleguide are in the linter.

I'd want to do a little more user research before we change anything at this point. I think we're making the assumption that creating a separate list would improve the user experience. We're also assuming that this is a problem for the majority of our users. I think it'd be good to do some very basic, very sparse user testing of our styleguide and identify this as an actual problem first.

from frontend.

jeremiak avatar jeremiak commented on July 18, 2024

👍 to this:

I think it'd be good to do some very basic, very sparse user testing of our styleguide and identify this as an actual problem first.

from frontend.

msecret avatar msecret commented on July 18, 2024

We're going to hold off on this for now to allow time for more research.

from frontend.

maya avatar maya commented on July 18, 2024

They do it nicely here: https://github.com/brigade/scss-lint/blob/master/lib/scss_lint/linter/README.md

from frontend.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.