Giter Site home page Giter Site logo

Comments (6)

20lives avatar 20lives commented on June 6, 2024 3

Hi everyone!
Sorry for my unavailability, was occupied with other things.

The last change did break a lot of stuff and I am sorry for that as well.

I think that reverting to the last version is the best decision (and "forcing" you to have dir="ltr/rtl" at the top level) is our best choice.

this will be done today, including a new release.

if you think that the other solution that came up is better, let's talk about it.

from tailwindcss-rtl.

20lives avatar 20lives commented on June 6, 2024 2

Finally fixed, use version 0.9.0.

from tailwindcss-rtl.

Reex11 avatar Reex11 commented on June 6, 2024

I think the issue is that the rule :not([dir="rtl"]) is for the current element (regardless of the parent) so I think it would be better if we assigned specified it to the body body:not([dir="rtl"])

from tailwindcss-rtl.

Reex11 avatar Reex11 commented on June 6, 2024

I created a PR #45 to fix this issue. It will depend on the body direction.
Check it out and let me know what you think.

from tailwindcss-rtl.

vltansky avatar vltansky commented on June 6, 2024

@20lives merge please

from tailwindcss-rtl.

StormVanDerPol avatar StormVanDerPol commented on June 6, 2024

maybe it's better to revert to dir="ltr" and just require either ltr or rtl on the top level layout element of your choosing, since #45 locks it to the body element, which may go against some people their use case.

e.g. @cdes in his screenshot uses the html element. Others may place the dir attribute further down the tree.

from tailwindcss-rtl.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.