Giter Site home page Giter Site logo

Comments (5)

osstony avatar osstony commented on August 25, 2024

Should we create a function which does a Unicode and in the case of python 2.7 check as well as a function to convert from either a unicode or again int he case of python 2.7 a string? There are many places where PyUnicode_Check and PyUnicode_AsUTF8 are being invoked. Adding in PyString checks with #if statements could get messy.

from unrealenginepython.

rdeioris avatar rdeioris commented on August 25, 2024

I think you can improve this:

https://github.com/20tab/UnrealEnginePython/blob/master/Source/UnrealEnginePython/Private/UnrealEnginePython.cpp#L12

to support strings with PyString_Check()

from unrealenginepython.

osstony avatar osstony commented on August 25, 2024

Should we add a generic check function along side this? This function will perform the convert but we are doing many checks for Unicode as well.

from unrealenginepython.

rdeioris avatar rdeioris commented on August 25, 2024

Can we close it ?

from unrealenginepython.

osstony avatar osstony commented on August 25, 2024

All seems well with the patch, thanks!

from unrealenginepython.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.