Giter Site home page Giter Site logo

Comments (6)

nineinchnick avatar nineinchnick commented on July 17, 2024

You can index the row data column and add a condition for your primary key. You don't need to extract it into a separate column. Also, consider cases when primary key is composite, that is it's more than one column. You'd end up with something similar to row data column.

I don't know exactly how it performs in hstore, but it works fine in my version where I use jsonb instead. See #12.

from audit-trigger.

3nids avatar 3nids commented on July 17, 2024

The index on such a column would be quite large I suppose.
I would see this as an option when calling audit_table.

from audit-trigger.

nineinchnick avatar nineinchnick commented on July 17, 2024

I have an example, I'm using my jsonb version:

  • table size is 900MB with 1002888 rows
  • row_data index is 245MB
  • other indexes are about 50MB
  • indexing only the id field in row_data takes only 7,5MB

Full index:

CREATE INDEX logged_actions_row_data_idx
  ON audits.logged_actions
  USING gin
  (row_data jsonb_path_ops)

PK index:

CREATE INDEX logged_actions_row_data_pk_idx
  ON audits.logged_actions
  USING gin
  ((row_data -> 'id'));

The PK index makes sense when you have consistent PK naming.

Now to compare the usage of those two indexes:

select * from audits.logged_actions where row_data @> '{"id": 78}'
'Bitmap Heap Scan on logged_actions  (cost=307.77..4037.14 rows=1003 width=956)'
'  Recheck Cond: (row_data @> '{"id": 78}'::jsonb)'
'  ->  Bitmap Index Scan on logged_actions_row_data_idx  (cost=0.00..307.52 rows=1003 width=0)'
'        Index Cond: (row_data @> '{"id": 78}'::jsonb)'
select * from audits.logged_actions where row_data->'id' @> '78'
'Bitmap Heap Scan on logged_actions  (cost=23.77..3755.65 rows=1003 width=956)'
'  Recheck Cond: ((row_data -> 'id'::text) @> '78'::jsonb)'
'  ->  Bitmap Index Scan on logged_actions_row_data_pk_idx  (cost=0.00..23.52 rows=1003 width=0)'
'        Index Cond: ((row_data -> 'id'::text) @> '78'::jsonb)'

Adding conditions for table names doesn't change the index used.

from audit-trigger.

3nids avatar 3nids commented on July 17, 2024

wow, thanks a lot for this great feedback.
I didn't know you could index only a single column of a hstore.

from audit-trigger.

nineinchnick avatar nineinchnick commented on July 17, 2024

I don't know if it's possible in hstore. I'm only testing jsonb. I just think the numbers should be similar for hstore.

from audit-trigger.

3nids avatar 3nids commented on July 17, 2024

anyway, I might also try your jsonb version. thanks again.

from audit-trigger.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.