Comments (9)
The one you've submitted in the PR seems to be working. I want to do some more in depth tests when I have some time or if you'd like to submit some tests for it in the PR as a comment on the thread I'd be more than happy to look it over. Either way, this is a helpful find!
from 30-seconds-of-interviews.
right never reported test results did I... yeah it's working in all cases. Never found an edge case that could be considered a problem except for a SO if I went deep with auto generating object references
from 30-seconds-of-interviews.
Please open a PR with the proposed change in the answer's code sample. Thanks! 😊
from 30-seconds-of-interviews.
i'm going to reopen this to allow for easier discussion from #100
from 30-seconds-of-interviews.
Are you saying this error or that it returns true with 1
and 2
used as arguments?
from 30-seconds-of-interviews.
yes.and it will return true with { a:1 } amd { a: 2} used as arguments.The code can't work.
from 30-seconds-of-interviews.
This is a confirmed problem. We might need to add better handling for this.
Or we could just use JSON.stringify(a) === JSON.stringify(b)
as a short and sloppy...
But like I said it's sloppy and only really applies to POJO(Plain Old JavaScript Object)
from 30-seconds-of-interviews.
We can solve it by adding a if statement.You can see my code above.
from 30-seconds-of-interviews.
@chenjigeng thanks for noticing this. The PR is merged. ❤️
from 30-seconds-of-interviews.
Related Issues (20)
- Refactor + Optimize builder scripts HOT 1
- New feature proposal: React Questions HOT 8
- Give each question a ID to allow linking to specific questions. HOT 3
- Question is displayed twice in README.md HOT 13
- Reword the `setState` question to explicitly reference React HOT 1
- An error in JS question: What is a stateless component? HOT 1
- The answer of the question "In which states can a Promise be?" have to include the state <settled> HOT 2
- Comment is showing on main website under 'Good to hear' HOT 1
- update stateful-components.md HOT 8
- A problem with 'What is Big O Notation?'
- A problem with 'What is Big O Notation?' HOT 3
- questions.json is not built correctly when a question is missing a section HOT 1
- Found a typo HOT 2
- Question on CSS sibling selectors is partially wrong HOT 1
- Feature Request: Dark Mode HOT 2
- Home URL is broken 404 HOT 2
- Plans for the second version HOT 11
- Accessibility questions HOT 9
- The answer to the "What are JavaScript data types?" question is no longer correct HOT 1
- A small request HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 30-seconds-of-interviews.