Giter Site home page Giter Site logo

Comments (10)

Algorush avatar Algorush commented on July 20, 2024 1

So addtitional tasks here:

from 3dstreet.

kfarr avatar kfarr commented on July 20, 2024 1

@Algorush let's ignore this issue for now, made a separate ticket for it: #539

from 3dstreet.

kfarr avatar kfarr commented on July 20, 2024 1

@Algorush I like the idea, but can we just put this in metadata instead of a new thing? Like how we fetch title?

Also what we're talking about could be called global state. Right now it's managed in multiple places so I'm not excited about adding another

  • React app toolbar.js component state (I think, since that's where a lot of the save / load logic is)
  • metadata component on scene
  • STREET.coord (proposed)

from 3dstreet.

Algorush avatar Algorush commented on July 20, 2024

I discovered that the aframe-loader-3dtitle-component is not the latest version. And it looks like the version used is not from the 3DStreet repository: https://github.com/3DStreet/aframe-loader-3dtiles-component
by looking at the list of attributes in the code of the component in the minified version. Also 3dtiles are not updated when switching to Editor. No copyrightEl attribute and other things

from 3dstreet.

kfarr avatar kfarr commented on July 20, 2024

Yes you're right, it will all need to be updated and the working changes that we used for the glitch demo (like this one) brought to this repo

from 3dstreet.

Algorush avatar Algorush commented on July 20, 2024

How to display these in the scene / disable editing:

  • Properties panel should be disabled for entities with "autocreated" class.

That is, add a new feature in the Editor to hide the properties panel for entities with "autocreated" class.

from 3dstreet.

kfarr avatar kfarr commented on July 20, 2024

Properties panel should be disabled for entities with "autocreated" class.

That is, add a new feature in the Editor to hide the properties panel for entities with "autocreated" class.

No we do not want to hide it. We definitely want to show it but to make it disabled (user cannot edit it). Eventually user will have the ability to determine if an item should switch to be a manual object instead of autocreated

from 3dstreet.

Algorush avatar Algorush commented on July 20, 2024

Properties panel should be disabled for entities with "autocreated" class.

That is, add a new feature in the Editor to hide the properties panel for entities with "autocreated" class.

No we do not want to hide it. We definitely want to show it but to make it disabled (user cannot edit it). Eventually user will have the ability to determine if an item should switch to be a manual object instead of autocreated

Does aframe-inspector have an option to disable the ability to edit parameters?
If not or if it has, what option is better to implement:

  1. Hide the button to open the right panel
  2. Leave the button and the ability to open the panel. Leave the position, rotation, scale fields for editing. And make the rest uneditable
  3. Or maybe another option?

from 3dstreet.

Algorush avatar Algorush commented on July 20, 2024

I'll store lat, long, height in a global STREET.coord ?
That is, receive them from GeoModal window and save them in STREET.coord. When user click on the Layer cards mapbox/google3d, get coordinates from there and open map with these coordinates. And also when click on the button "Update with 3D Map" existing maps and STREET.coord value will be updated with new coords. This will also be useful later for saving coordinates in JSON.

from 3dstreet.

kfarr avatar kfarr commented on July 20, 2024

#540

from 3dstreet.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.