Comments (8)
See my comments 3DStreet/3dstreet-editor#185 (comment)
from 3dstreet.
See my comments 3DStreet/3dstreet-editor#185 (comment)
Thanks, I read the comments but didn't look in detail yet. Yes, the parameters of the Ortho camera are different from the Perspective camera. Perhaps this is causing the problem. I studied ortho and perspective cameras while working with 3dtiles-loader, I'll try to fix this
from 3dstreet.
Good luck. I spend about 2 hours trying without success.
from 3dstreet.
Oh I see that EditorControls is also messing around the left bottom right top property of the ortho camera
3dstreet/src/editor/lib/EditorControls.js
Lines 120 to 134 in 5d6bacc
I missed that code when I tried to fix the issue.
from 3dstreet.
3dstreet/src/editor/lib/viewport.js
Line 212 in 5d6bacc
probably just need to be executed on resize
from 3dstreet.
I made it work. I'll add a PR later. in window resize I first calculate FrustumSize
, then add parameters for ortho camera. It works with Plan View
in inspector, but not with Cross Section View
:
if (inspector.camera.isOrthographicCamera) {
const frustumSize = inspector.camera.top - inspector.camera.bottom;
inspector.camera.left = -frustumSize * aspect / 2;
inspector.camera.right = frustumSize * aspect / 2;
inspector.camera.top = frustumSize / 2;
inspector.camera.bottom = -frustumSize / 2;
}
so I need to do this work in Cross Section View
also
from 3dstreet.
I fixed it with Cross Section View
too.
I'll try to add this fix in aframe repo in resize
event function here: https://github.com/aframevr/aframe/blob/66baa9c8128caf9199e8a773ca4d637a25947d06/src/core/scene/a-scene.js#L577
from 3dstreet.
Added PR here in 3DStreet. I was unable to clone the aframe repository due to an error during the download, perhaps a problem with my unstable connection in a rural area
from 3dstreet.
Related Issues (20)
- saving and reloading a scene makes streetmix / street component properties not visible HOT 8
- improvements to asset metadata
- create 20 metadata entries in cardsData.js for models
- fix / update variant launch ar key HOT 1
- Last Login in users table doesn't seem to be accurate
- google.maps.Marker is deprecated
- 'DOMSubtreeModified' mutation event is deprecated (in assets.js)
- add undo for geospatial
- Error in in Right Panel after making New scene HOT 1
- Record canvas in posthog HOT 2
- flickering menu returns
- wrong camera angle when switch to Cross Section View after zooming in on Plan View HOT 1
- editing primitive geometry properties does not work HOT 2
- undo error when using hand tool instead of pointer tool HOT 1
- ability to select crosswalks and other stencils HOT 1
- posthog events for payment modal HOT 1
- sometimes 3dtiles do not load HOT 1
- additional undo commands to support autosave
- cleanup left-hand properties panel
- Camera button HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from 3dstreet.