Images spawn on every tmux panes.

[S0mbr3]

Images spawn on every tmux panes.

[dankamongmen]

@dankamongmen does notcurses do anything special to handle switching panes in tmux?

nope, very little tmux-specific code

[3rd]

Yes, it only handles window switching, with a massive hack. In theory it could handle panes as well, need to check.

[3rd]

Hey, yes, there's no handling for tmux pane switching yet, but it's on the list!

[benlubas]

@3rd have you looked into this at all? If you have any info on where to start supporting something like this I'd be more than happy to tackle it.

Starting to grow tired of switching tabs and then having to go back to close an image

If you haven't looked at this at all I'm also happy to look into it, just thought I'd ask first.

[3rd]

Couldn't find a way to do it without adding a tmux script, still exploring.

[3rd]

@benlubas would it be acceptable to hide/show the images on nvim focus lost/gained? It would also hide them when switching to a different pane in the same window.

[benlubas]

Yeah my first thought was focus lost/gained, personally I wouldn't have a problem with images disappearing when switching panes but I could see why others might.

I wonder what notcurses does.. maybe we can ask dank

[benlubas]

I've tried a simple implementation with focus lost, and it's unfortunately not working.

(P() is a function that prints using vim.inspect)

if state.options.tmux_mode then
  local held_images = {}
  print("tmux mode")
  -- hide all images on focus lost
  vim.api.nvim_create_autocmd("FocusLost", {
    group = group,
    callback = function(_au)
      print("focus lost")
      vim.schedule(function()
        held_images = api.get_images()
        P(held_images)
        for _, current_image in ipairs(held_images) do
          current_image:clear()
        end
      end)
    end,
  })
  -- re-render on focus gained
  vim.api.nvim_create_autocmd("FocusGained", {
    group = group,
    callback = function(_au)
      print("focus gained")
      for _, current_image in ipairs(held_images) do
        current_image:render()
      end
    end,
  })
end

[3rd]

Added a new option editor_only_render_when_focused in 133926c that should be an ok workaround until we figure something else out ; it's not tied to Tmux in any way, just a general option.

The more advanced way would be to make a plugin for Tmux that sends a message to nvim, either through the remote protocol (would require remote control enabled), by sending keys (yuck), or by writing to a socket file (probably).

I think it's good enough for now.

[3rd]

Reopening, doesn't seem to work properly, looking into it.

[benlubas]

Haha, I beat you to it. That implementation works for focus via window manager, but tmux switching, while it triggers the auto command, doesn't actually clear the image.

[3rd]

The Neovim part seems ok, it's a clearing issue, which is better than the events not working. I think it doesn't have time to output the escape codes for clearing.

image-focus.mp4

[3rd]

damn
tmux/tmux#3265
tmux/tmux#3274
tmux/tmux#3001

[benlubas]

@dankamongmen does notcurses do anything special to handle switching panes in tmux?

[3rd]

Found a way to do it by finding the active tty for the current tmux session and writing Kitty's clear-all control sequence in that one. It's hacky, but it works. Just needs some changes to make the "restore" work.

[3rd]

Linking PR: #45

[3rd]

This is now in master, needs tmux_show_only_in_active_window = true and set -g visual-activity off in Tmux 🎉

[petobens]

Hi! In the following gif I open a split (pane) I see the image in the pane below (even though I'm using the tmux_show_only_in_active_window setting):