Giter Site home page Giter Site logo

Overlap with floating windows about image.nvim HOT 7 CLOSED

3rd avatar 3rd commented on June 9, 2024
Overlap with floating windows

from image.nvim.

Comments (7)

3rd avatar 3rd commented on June 9, 2024 1

@yingzhu146 Hey, thanks for the issue.
Performance should be better now, and the resize issue should be fixed when using Kitty, can you try the latest version?
Looking at your image it seems like the positioning is very off, can you share a sample document & images to reproduce that?
For the floating windows I'm planning on implementing a masking mechanism soon, will update here.
Thanks again!

from image.nvim.

3rd avatar 3rd commented on June 9, 2024 1

@yingzhu146 Added two new config options for toggling a window's images when it's overlapped, try setting window_overlap_clear_enabled to true.
We have what we need for the masking math, but the magick rock isn't very friendly for this task, I guess this solution is ok for now.

from image.nvim.

yingzhu146 avatar yingzhu146 commented on June 9, 2024

Actually - for others finding this, default size is possible via:

max_width = 50, max_height = 50 config options

still not finding the right size however
20230707-223144

and the following is still often triggered when moving over objects (leading to crashes sometimes)

Error executing lua callback: ...ocal/share/nvim/lazy/image.nvim/lua/image/utils/term.lua:25: Failed to get terminal size
stack traceback:
	[C]: in function 'assert'
	...ocal/share/nvim/lazy/image.nvim/lua/image/utils/term.lua:25: in function 'get_size'

from image.nvim.

yingzhu146 avatar yingzhu146 commented on June 9, 2024

Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!

There's still some image overlaps with some text, but that's a different issue and not a huge problem!
20230710-183900

from image.nvim.

3rd avatar 3rd commented on June 9, 2024

Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!

There's still some image overlaps with some text, but that's a different issue and not a huge problem!
20230710-183900

Awesome!

It looms like it still renders at the wrong position, off by one on both x and y. Could you share a small config & documenr sample to reproduce this?
I'd like to fix it. Is it a Neorg file?

About the initial load, it now handles resizing and cropping in two steps, and both are cached.

I'm thinking of dropping magick and making a separate helper with Go to handle all image operations, as well as masking, compositing, and backend communication. Would be testable, have better perf, and will be embeddable in anything, not just Neovim.

from image.nvim.

yingzhu146 avatar yingzhu146 commented on June 9, 2024

Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!
There's still some image overlaps with some text, but that's a different issue and not a huge problem!
20230710-183900

Awesome!

It looms like it still renders at the wrong position, off by one on both x and y.

c957678 seems to have fixed this!

Could you share a small config & documenr sample to reproduce this? I'd like to fix it. Is it a Neorg file?

Not Neorg, just markdown created in logseq.

About the initial load, it now handles resizing and cropping in two steps, and both are cached.

I'm thinking of dropping magick and making a separate helper with Go to handle all image operations, as well as masking, compositing, and backend communication. Would be testable, have better perf, and will be embeddable in anything, not just Neovim.

that sounds great! the luarocks installation process isn't exactly the easiest go via a proper build.lua https://www.reddit.com/r/neovim/comments/14n5aom/plugin_authors_lazynvim_now_supports_buildlua/
might be a better experience!

from image.nvim.

3rd avatar 3rd commented on June 9, 2024

Awesome, glad it works! Yeah, wasn't able to do masking with magick and the rock isn't compatible with distros like NixOS.

from image.nvim.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.