Comments (7)
@yingzhu146 Hey, thanks for the issue.
Performance should be better now, and the resize issue should be fixed when using Kitty, can you try the latest version?
Looking at your image it seems like the positioning is very off, can you share a sample document & images to reproduce that?
For the floating windows I'm planning on implementing a masking mechanism soon, will update here.
Thanks again!
from image.nvim.
@yingzhu146 Added two new config options for toggling a window's images when it's overlapped, try setting window_overlap_clear_enabled
to true.
We have what we need for the masking math, but the magick rock isn't very friendly for this task, I guess this solution is ok for now.
from image.nvim.
Actually - for others finding this, default size is possible via:
max_width = 50, max_height = 50
config options
still not finding the right size however
and the following is still often triggered when moving over objects (leading to crashes sometimes)
Error executing lua callback: ...ocal/share/nvim/lazy/image.nvim/lua/image/utils/term.lua:25: Failed to get terminal size
stack traceback:
[C]: in function 'assert'
...ocal/share/nvim/lazy/image.nvim/lua/image/utils/term.lua:25: in function 'get_size'
from image.nvim.
Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!
There's still some image overlaps with some text, but that's a different issue and not a huge problem!
from image.nvim.
Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!
There's still some image overlaps with some text, but that's a different issue and not a huge problem!
Awesome!
It looms like it still renders at the wrong position, off by one on both x and y. Could you share a small config & documenr sample to reproduce this?
I'd like to fix it. Is it a Neorg file?
About the initial load, it now handles resizing and cropping in two steps, and both are cached.
I'm thinking of dropping magick and making a separate helper with Go to handle all image operations, as well as masking, compositing, and backend communication. Would be testable, have better perf, and will be embeddable in anything, not just Neovim.
from image.nvim.
Amazing, works like a charm! The initial loading appears quite a bit slower now but both movement over images and not overlapping over windows are now solved so I'll take the slower initial loads, so closing this!
There's still some image overlaps with some text, but that's a different issue and not a huge problem!
Awesome!
It looms like it still renders at the wrong position, off by one on both x and y.
c957678 seems to have fixed this!
Could you share a small config & documenr sample to reproduce this? I'd like to fix it. Is it a Neorg file?
Not Neorg, just markdown created in logseq.
About the initial load, it now handles resizing and cropping in two steps, and both are cached.
I'm thinking of dropping magick and making a separate helper with Go to handle all image operations, as well as masking, compositing, and backend communication. Would be testable, have better perf, and will be embeddable in anything, not just Neovim.
that sounds great! the luarocks installation process isn't exactly the easiest go via a proper build.lua
https://www.reddit.com/r/neovim/comments/14n5aom/plugin_authors_lazynvim_now_supports_buildlua/
might be a better experience!
from image.nvim.
Awesome, glad it works! Yeah, wasn't able to do masking with magick and the rock isn't compatible with distros like NixOS.
from image.nvim.
Related Issues (20)
- sticky images HOT 3
- Document integration clears user added images in markdown files HOT 3
- Link and preview overlap in markdown integration HOT 2
- Statusline hidden if cmdheight = 0 HOT 2
- Image is still shown when switched to another tmux window HOT 5
- Not working on Alacritty. HOT 2
- [bug] Unfolding images causes them to draw at the cursor position (and other weird folding behavior) HOT 1
- [bug] get images api changed in the namespace commit HOT 1
- [BUG] Image display override floating windows HOT 4
- Windows support? HOT 3
- Image ignores soft text wrapping HOT 1
- [feature request] Obsidian Link support HOT 3
- [bug] removing and adding image in buffer while images are displayed in a split HOT 1
- YALRMI: Yet Another LuaRocks Magick Issue HOT 7
- The picture cannot be displayed and the corresponding position is garbled. HOT 3
- Messes with lualine HOT 2
- Luarock magick abandoned HOT 19
- GIF rendered incorrectly HOT 3
- Background of telescope became transparent HOT 1
- `nvim: src/unix/core.c:148: uv_close: Assertion '!uv__is_closing(handle)' failed` when closing nvim; doesn't happens with `backend = "ueberzug"` HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from image.nvim.