Use postprocessing scripts without copying them

[5axes]

Use postprocessing scripts without copying them

[fieldOfView]

It doesn't work, but that is not because the PostProcessingPlugin loads before your plugin, but because the PostProcessingPlugin does not use the resource search paths correctly :-(

https://github.com/Ultimaker/Cura/blob/4.8/plugins/PostProcessingPlugin/PostProcessingPlugin.py#L145
Instead of using getStoragePath, it should be using getAllPathsForType. Oh well, it was worth the try.

[nallath]

I just merged the PR.

[5axes]

Unfortunatly no it doesn't work. Your solution is correct but as the PostProcessingPlugin is launched before my custom plugin, even if the code is correct the scripts are not loaded byt the PostProcessingPlugin via the function : def loadScripts(self, path: str) -> None:

2021-01-18 14:36:53,431 - INFO - [MainThread] UM.Logger.info [122]: Loaded plugin PostProcessingPlugin
...
2021-01-18 14:36:54,382 - INFO - [MainThread] UM.Logger.info [122]: Loaded plugin SimpleShapes

[nallath]

Whoops, that's our bad :(

[fieldOfView]

It just might be my bad ;-)

nallath/PostProcessingPlugin@12d4d17#diff-29915b71ed69033c978493b7def0019f64e3064ac80c4ab127d74ac5d3c3628bR159

[fieldOfView]

Here's a fix: Ultimaker/Cura#9147

[nallath]

It just might be my bad ;-)

nallath/PostProcessingPlugin@12d4d17#diff-29915b71ed69033c978493b7def0019f64e3064ac80c4ab127d74ac5d3c3628bR159

Well, we were still paying you at that time, so it's our fault :P

[fieldOfView]

Nope, this was a year and 2 days after my last day on the team... But it was your fault for not spotting it in the review ofcourse. It is always your fault.

[nallath]

It is always your fault.

Damn right! :D

[5axes]

Ok I have modified the source code V1.3.0. Don't need to use the Copy scripts function anymore. Have been removed from the menu thanks for your help @nallath and @fieldOfView