Comments (3)
Sorry about the issue, it looks like it was an oversight during the addition of optional CSS class rendering functionality. The tests all had CSS class names that didn't trigger the CSS safety features, hence missing it.
I've done a PR, does that look like what you were expecting?
For background, CSS class names are sanitised by default, since templ can't tell whether they came from a user controlled variable (unsafe), or a programmer controlled constant (safe).
It looks like you spotted that you have to mark Go variables that you've set yourself (i.e. programmer controlled) as being safe by converting them to a templ.ConstantCSSClass
type using the templ.SafeClass
function.
But... I missed the code to handle that specific KV generic type.
Thanks for the great bug report and the nice words! 😁
from templ.
@a-h glad the issue with using SafeClass
in KV
is resolved. Looking at the PR, I realised that I should have been using SafeClass
rather than SafeCSS
in the string element and that resolved my issue in that case too.
Thanks for the help. Once I've got a bit further with the conversion to templ I'll try and add some extra docs for CSS,
from templ.
@a-h thanks for quick response and the PR. It looks good to me, I'll check out that version in the code base later this morning and report back.
from templ.
Related Issues (20)
- proxy injected script shouldn't error when re-evaluated
- Errors in go portions of a template report line numbers in the go file instead of the templ file HOT 2
- Golang code generated always import github.com/a-h/templ even if not used HOT 2
- Issue with for loop parsing for: expected nodes, but none were found: line 96, col 13 HOT 3
- vscode: show _templ.go files greyed out? HOT 8
- Can/could templ support plain text? HOT 3
- lsp: formatting malformed when CSS expressions are too long HOT 6
- proposal: add templ.JSONScript and templ.JSON functions HOT 4
- proposal: deprecate CSS components in favour of 3rd party CSS pre-processors HOT 7
- Bug: hot reloader adds a wrong reload script in nested body responses HOT 1
- fmt: broken mutliline raw string formatting
- Website SEO HOT 1
- proposal: Allow for primitives & fmt.Stringer in addition to string in templates HOT 2
- vscode: Bad highlighting when using generic functions HOT 3
- Binary in`templ_Darwin_arm64.tar.gz` v0.2.697 displays version 0.2.696 HOT 8
- -stdout sends error report to output file HOT 3
- bug: script elements don't render script templates
- lsp: support the organizeImports code action HOT 3
- Wasm support for interacting with the DOM HOT 3
- generator: can't use iterator value in for loop HOT 8
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from templ.