Detection with the ModuleConcatenationPlugin

[aackerman]

Detection with the ModuleConcatenationPlugin

[aackerman]

Thanks for the info, I haven't done much testing with Webpack 3. I'll look into it.

[aackerman]

@gpoitch I believe these plugins are usually run in order, when you were using the ModuleConcatenationPlugin was it before the CircularDependencyPlugin?

[gpoitch]

I tested both before and after. I believe the issue is that this plugin runs on the 'done' plugin event, at which point the ModuleConcatenationPlugin has already did its thing (merged/hoisted dependencies).

It makes sense that some circular dependencies could actually be eliminated by what the ModuleConcatenationPlugin does, but not all of them. I still saw some undefined imports and no warning from this plugin.

[gpoitch]

@aackerman Here's a minimal reproduction: https://github.com/gpoitch/webpack-circ-dep-bug

[aackerman]

@gpoitch thanks, I imagine this will help a lot in addressing this issue.

[aackerman]

This should be fixed in version 4.1.0

[gpoitch]

👏 thanks!