Cannot read property 'tap' of undefined

[aackerman]

Cannot read property 'tap' of undefined

[unlight]

@aackerman
create-react-app 3.0.0 Clean install works.
So, I do not have complains about plugin, it's my environment issue.
(As I said... debris)

Thank you for great plugin.

[aackerman]

Hi @kruglay can you please include you exact versions of the plugin, webpack, and if possible a stack trace. I can take a look at this later tonight.

[kruglay]

Here a screen with error
"circular-dependency-plugin": "5.0.2",
"webpack": "4.27.1",

stack trace from log file:

0 info it worked if it ends with ok
1 verbose cli [ '/home/kruglay/.nvm/versions/node/v10.11.0/bin/node',
1 verbose cli   '/home/kruglay/.nvm/versions/node/v10.11.0/lib/node_modules/npm/bin/npm-cli.js',
1 verbose cli   'run',
1 verbose cli   'start',
1 verbose cli   '--scripts-prepend-node-path=auto' ]
2 info using [email protected]
3 info using [email protected]
4 verbose run-script [ 'prestart', 'start', 'poststart' ]
5 info lifecycle [email protected]~prestart: [email protected]
6 info lifecycle [email protected]~start: [email protected]
7 verbose lifecycle [email protected]~start: unsafe-perm in lifecycle true
8 verbose lifecycle [email protected]~start: PATH: /home/kruglay/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/npm-lifecycle/node-gyp-bin:/home/kruglay/MVS/dash/node_modules/.bin:/home/kruglay/.nvm/versions/node/v10.11.0/bin:/home/kruglay/.local/share/umake/bin:/usr/local/sbin:/usr/local/bin:/usr/sbin:/usr/bin:/sbin:/bin:/usr/games:/usr/local/games:/snap/bin:/usr/lib/jvm/java-8-oracle/bin:/usr/lib/jvm/java-8-oracle/db/bin:/usr/lib/jvm/java-8-oracle/jre/bin
9 verbose lifecycle [email protected]~start: CWD: /home/kruglay/MVS/dash
10 silly lifecycle [email protected]~start: Args: [ '-c', 'node scripts/start.js' ]
11 silly lifecycle [email protected]~start: Returned: code: 1  signal: null
12 info lifecycle [email protected]~start: Failed to exec start script
13 verbose stack Error: [email protected] start: `node scripts/start.js`
13 verbose stack Exit status 1
13 verbose stack     at EventEmitter.<anonymous> (/home/kruglay/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/npm-lifecycle/index.js:301:16)
13 verbose stack     at EventEmitter.emit (events.js:182:13)
13 verbose stack     at ChildProcess.<anonymous> (/home/kruglay/.nvm/versions/node/v10.11.0/lib/node_modules/npm/node_modules/npm-lifecycle/lib/spawn.js:55:14)
13 verbose stack     at ChildProcess.emit (events.js:182:13)
13 verbose stack     at maybeClose (internal/child_process.js:962:16)
13 verbose stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:251:5)
14 verbose pkgid [email protected]
15 verbose cwd /home/kruglay/MVS/dash
16 verbose Linux 4.18.0-20.2-liquorix-amd64
17 verbose argv "/home/kruglay/.nvm/versions/node/v10.11.0/bin/node" "/home/kruglay/.nvm/versions/node/v10.11.0/lib/node_modules/npm/bin/npm-cli.js" "run" "start" "--scripts-prepend-node-path=auto"
18 verbose node v10.11.0
19 verbose npm  v6.4.1
20 error code ELIFECYCLE
21 error errno 1
22 error [email protected] start: `node scripts/start.js`
22 error Exit status 1
23 error Failed at the [email protected] start script.
23 error This is probably not a problem with npm. There is likely additional logging output above.
24 verbose exit [ 1, true ]

[unlight]

+-- [email protected]
`-- [email protected]

Error in version [email protected] - Cannot read property 'tap' of undefined
[email protected] - DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead

[aackerman]

@unlight do you have a stack trace you can include?

Version 5 of the plugin is expected to work with webpack >= 4.0.1 and I would expect that the warning DeprecationWarning: Tapable.plugin is deprecated. Use new API on .hooks instead is not for this plugin because the .hooks syntax is being used. https://github.com/aackerman/circular-dependency-plugin/blob/master/index.js#L21-L22

[aackerman]

I was also able to test this with Node 10 and webpack 4.29.6 and I didn't run into any issues.

[unlight]

Sorry, my bad. I pasted plugin to wrong place.
After create-react-app eject, I got webpack.config 650+ lines, there are several places with plugins section in resolve, modules, etc. I lost in debris.

Version 5.0.2 is working ok with [email protected] (but not with webpack after react-scripts eject, because it launches webpack in subprocess - that's why is hard to provide stack trace)

[aackerman]

@unlight can you include your version of create-react-app? I'm seeing this working with the defaults for these versions.

create-react-app 3.0.1
circular-dependency-plugin 5.0.2
webpack 4.29.6

I essentially ran the following on macOS

brew upgrade yarn
yarn create react-app test && cd test
yarn run eject
yarn add circular-dependency-plugin
# edit webpack.config.js in config
# add `const CircularDependencyPlugin = require('circular-dependency-plugin')
# add `new CircularDependencyPlugin()` to the plugins section
yarn start