Giter Site home page Giter Site logo

Comments (4)

aaugustin avatar aaugustin commented on June 16, 2024

The pattern you are showing (user = form.save()) logs a user in while bypassing all security features of Django. If you authenticated the user with authenticate(), the user would have a user.backend attribute and you wouldn't need to specify the authentication backend explicitly. That contributes to the issue here.


Providing a custom authentication backend is the recommended way to authenticate against another source in Django: https://docs.djangoproject.com/en/stable/topics/auth/customizing/

It is also necessary for authenticate() to work as documented.

That being said, some use cases can work without the authentication backend. You can remove it from your configuration. If all API you need still work, I think you're good to go.


I'm going to take a deeper look at this. I'm keeping it open as a documentation issue.

from django-sesame.

aaugustin avatar aaugustin commented on June 16, 2024

Wait - get_user() calls authenticate() so nothing will work without the authentication backend.

from django-sesame.

silviogutierrez avatar silviogutierrez commented on June 16, 2024

Right, it's currently needed as is.

But really, the meat of the library is in parse_token.

So just doing parse_token() + login() in get_user would work. No need to go through the backend system.

I guess I see custom backends as "authenticating against another source" where source is "active directory" or "SSO" or "something other than a local DB table".

Here's simplified pseudo code for get_user:

from django.contrib.auth import login

def get_user(request_or_sesame, scope="", max_age=None, *, update_last_login=None):
    # ... setup logic

    if user := parse_token(...args):
        login(
            request,
            user,
        )

    if update_last_login is None:
        update_last_login = settings.ONE_TIME
    if update_last_login:
        user.last_login = timezone.now()
        user.save(update_fields=["last_login"])

    return user

Either way, library works great as is. Just looking to simplify the setup (since AUTHENTICATION_BACKENDS isn't in the default settings file generated by startproject). I'll close this.

from django-sesame.

aaugustin avatar aaugustin commented on June 16, 2024

I'm not sure I will do something but I'd like to think a bit more about it :-) I'm keeping it open for myself. Thanks for sharing that feedback!

from django-sesame.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.