Giter Site home page Giter Site logo

Comments (18)

ronniebarker avatar ronniebarker commented on June 2, 2024 4

Seems to be only when we have width='nnn' in the asl-google-signin-button - but why is that breaking it and why now?

from angularx-social-login.

Nas3nmann avatar Nas3nmann commented on June 2, 2024 3

FYI: For now we managed to workaround this issue by providing the width value including px suffix.

<asl-google-signin-button 
    type="standard"
    logo_alignment="center"
    width="240px"
    size="large">
</asl-google-signin-button>

from angularx-social-login.

AntoninKadrmas avatar AntoninKadrmas commented on June 2, 2024 2

image
Hi I found the same page and with px suffix it work for me as I expected.

And if you add in your code style="width:300px" (or whatever else length you are looking for) on asl-google-signin-button component it will have the correct length from the begining when the button is loaded. Else it will load shrink and then it will dynamically resize on specified length.

from angularx-social-login.

giacomodefra avatar giacomodefra commented on June 2, 2024 2

I fixed using the proprety with [width]="400" (not width="400")

<asl-google-signin-button type="standard" size="large" [width]="400" class="mx-5"></asl-google-signin-button>

from angularx-social-login.

exptom avatar exptom commented on June 2, 2024 1

I'm getting the same error when I specify the width attribute. I can't see a change in google's docs.

from angularx-social-login.

aluuu avatar aluuu commented on June 2, 2024 1

I've posted a message with link to this issue via feedback form on the Google's documentation page (see button 'Send feedback').

I'd suggest to people who face the same issue - post the reports there because it's either documentation should be fixed or the library's implementation should conform with the documentation. Authors of angularx-social-login could potentially fix the issue at hand, but you never know when Google would decide to change the library implementation again.

from angularx-social-login.

AntoninKadrmas avatar AntoninKadrmas commented on June 2, 2024 1

Hi I had same problem and I fixed it by changing property width="300" of asl-google-signin-button component to width="300px".

from angularx-social-login.

jpike88 avatar jpike88 commented on June 2, 2024 1

classic google junk.

adding 'px' on the end of my width amount worked but I had css animations showing the div it was in, now it causes some kind of reflow at the end, and the animation 'clunks' when finished into the final look.

from angularx-social-login.

giacomodefra avatar giacomodefra commented on June 2, 2024

image

I have the same problem, I haven't made any recent changes and my applications worked perfectly with the login, now I have this error in the console.

from angularx-social-login.

aluuu avatar aluuu commented on June 2, 2024

It seems like google's client library stopped accepting numbers-as-strings if provided as an input to the renderButton function.

Example to reproduce:

<html>
<head>
  <meta name="google-signin-client_id" content="YOUR_CLIENT_ID.apps.googleusercontent.com">
</head>
<body>
  <div id="my-signin2"></div>
  <script src="https://accounts.google.com/gsi/client"></script>
  <script>
    google.accounts.id.initialize();
    google.accounts.id.renderButton(document.getElementById('my-signin2'), {
    'width': 200,
    });
  </script>
</body>
</html>

If width passed as a number - all works button is rendered, once quoted - it fails with the following (similar to the above) stacktrace:

Uncaught Error: 
    $e https://accounts.google.com/gsi/client:128
    qp https://accounts.google.com/gsi/client:226
    $p https://accounts.google.com/gsi/client:245
    Mo https://accounts.google.com/gsi/client:243
    No https://accounts.google.com/gsi/client:215
    <anonymous> http://localhost:8000/google.html:10

from angularx-social-login.

aluuu avatar aluuu commented on June 2, 2024

Google's API documentation says that width is expected to be a string.

from angularx-social-login.

gedkul avatar gedkul commented on June 2, 2024

image
Strange that in dev pc login button is showing on all browsers, but in different pc or mobile google login button is missing.
And showing:
image
image
image

Edit:
Found that button request has 403 response code
image

Edit2:
Removed width attribute and working now:
<asl-google-signin-button title='Google' type='standard' size='large' theme="outline" shape="square" locale="en_US" text="signin"></asl-google-signin-button>

from angularx-social-login.

gedkul avatar gedkul commented on June 2, 2024

Hi I had same problem and I fixed it by changing property width="300" of asl-google-signin-button component to width="300px".

This doesn't fully fix problem. Its shows button but doesn't gives 300px width.

from angularx-social-login.

gedkul avatar gedkul commented on June 2, 2024

Found that in Google documentation is the same problem.
image

And when width is removed button is showing:
image

from angularx-social-login.

hoi4 avatar hoi4 commented on June 2, 2024

I have been using width="400" before. Using width="400px" causes the library to error. A temporary fix is to use width="399px"

from angularx-social-login.

formyjobonly avatar formyjobonly commented on June 2, 2024

I've posted a message with link to this issue via feedback form on the Google's documentation page (see button 'Send feedback').

I'd suggest to people who face the same issue - post the reports there because it's either documentation should be fixed or the library's implementation should conform with the documentation. Authors of angularx-social-login could potentially fix the issue at hand, but you never know when Google would decide to change the library implementation again.

@aluuu any updates?

from angularx-social-login.

aluuu avatar aluuu commented on June 2, 2024

I've posted a message with link to this issue via feedback form on the Google's documentation page (see button 'Send feedback').
I'd suggest to people who face the same issue - post the reports there because it's either documentation should be fixed or the library's implementation should conform with the documentation. Authors of angularx-social-login could potentially fix the issue at hand, but you never know when Google would decide to change the library implementation again.

@aluuu any updates?

Nope, no one replied yet.

from angularx-social-login.

chiragdp avatar chiragdp commented on June 2, 2024

any update on this issue? and also i want to make it adapt dynamic size can some one guide me how should i implement it?

from angularx-social-login.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.