Method to get last used logger?

[abap-logger]

Method to get last used logger?

[alpex8]

Maybe this is nothing that should be added to the "core" implementation. For a singleton like implementation and a logger group implementation I created a wrapper classes that provides this features. By using this approach I was able to keep the "abap-logger" clean and I`m able to pull some newer version if any would become available. Is this an option to you?

…

On Wed, Feb 7, 2018 at 11:36 AM, Andreas Kopp ***@***.***> wrote: Let's start a discussion. I am looking for a solution to get the *last used logger object*. Normally I initialize the logger class in the constructor of a using class, assign it to a private instance attribute and use it in the methods of the using class. Sometimes you want to use the same logging object in static methods of the class or in other classes in the context of the same program. I think it is not a good idea to pass the reference to the logger by a parameter. As ABAP does not offer dependency injection I would suggest to add some kind of static method like "get_last". When an instance of ZCL_LOGGER is created we could save this reference in a static attribute of ZCL_LOGGER, and return it if "get_last" is called. What do you think about this? — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#18>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AReWEFZnMTd0YbMRzXsS1gez8S6VRi_Yks5tSXyegaJpZM4R8fH1> .

[andkopp]

Yes, this is an option. This reminds me of the principle of "separation of concerns".

Should we extract the management of the instances (creation, get, etc.) completely into another factory like class?

[andkopp]

On the one hand, I just thought it would be easier to put this in the same class. On the other hand, we could add an interface (for the public methods add, a, e, w, i, s...) and a factory class which manages objects of ZCL_LOGGER.

[andkopp]

@epeterson320 Can you create a new branch where we can work on this? I already provided some changes on zcl_logger: I extracted the methods to an interface (zif_logger) and created a factory (zcl_logger_factory): https://github.com/andikade/ABAP-Logger. I would like to commit the changes to the new branch so we can discuss them.

[AlexandreHT]

I'm closing this issue because it's old and I don't think either it should be included in the library.