Log an object that contains messages with a new method add_loggable_object( )

[abap-logger]

Log an object that contains messages with a new method add_loggable_object( )

[andkopp]

Interesting approach. Can you extend your example on how the validate() method would add loggable messages to the notification (zif_loggable_object)? I assume that the implementation could be a repetition of code that is already implemented in zcl_logger like add(), e()...

[AlexandreHT]

You make a point. I was about to write the following enhancement proposition: I think we should extract this code in a functional class (eg zcl_abap_logger_tools).
I see the following advantages:

• it would simplify zcl_abap_logger
• it would allow these functions to be used elsewhere
• it would match the following Clean ABAP recommendation Don't mix stateful and stateless in the same class

To my opinion, the RTTS mapping code in the add method is the most valuable part of ABAP-Logger. It could be a co-product of the main zif_logger capability (as a matter of fact, I have multiple logging methods in my company and it would be nice to use this tool class).

NB: I think merging #49 into master is a prerequisite to this.

[andkopp]

I agree. RTTS mapping is the most valuable part. And I also agree on avoiding mixing of stateful and stateless code.
So zcl_logger would continue to implement zif_logger and delegate calls on add() to zcl_logger_tools, correct? Probably not an easy task to design the interface between separate those classes.

[AlexandreHT]

I was thinking about the following methods:

• map_sy_to_msg
  • returning a structure with ty/id/no/v1/v2/v3/v4
• is_struct_name_mappable_to_msg
  • importing a RTTS absolute name (type abap_abstypename)
  • returning a boolean
• is_struct_mappable_to_msg
  • importing a structure
  • returning a boolean
• map_structure_to_msg
  • importing a structure
  • returning a structure with ty/id/no/v1/v2/v3/v4
• map_structure_to_string_table : replaces add_structure
  • importing a (deep) structure
  • returning a table of strings
• drill_down_into_exception
  • importing exception type ref to cx_root
  • returning a table of exceptions
• map
  • importing any
  • exporting a structure with ty/id/no/v1/v2/v3/v4
  • exporting a table of strings
  • exporting a table of exceptions

Maybe zcl_abap_logger_data_mapper would be more suitable as a class name.

[andkopp]

This makes it much clearer. I like your approach.

[mbtools]

Closed by #90