Solution Manager doesn't have all the data types

[abap-logger]

Solution Manager doesn't have all the data types

[cavabap]

Actually this looks alot like issue #60 - although my customer is only running 7.40

[AlexandreHT]

Hi,
Please don't hesitate to send a PR. It's been on the todo list for a while :)

[cavabap]

Hi, Sorry, I’ve never contributed to an open source project, what is a PR? Thanks Martin

On Tue 9. Mar 2021 at 17:39, AlexandreHT ***@***.***> wrote: Hi, Please don't hesitate to send a PR. It's been on the todo list for a while :) — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#76 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AR3SYEZH43WGRF2UOPU7MJDTCZFM3ANCNFSM4Y3TBEUA> .

-- Martin Cavanagh

[AlexandreHT]

PR = Pull Request. That’s the process that allow to merge the changes in your repository into the main repository.
you’ll find some reference in the abapGit doc : https://docs.abapgit.org/guide-contributing.html

[andkopp]

Actually this looks alot like issue #60 - although my customer is only running 7.40

Yes, it is similar. ABAP-Logger should only rely on types that are available in a plain ABAP system.

[AlexandreHT]

What about unit tests. It makes sense to test it against actual types but maybe we should comment out these tests by default. What do you think?

[cavabap]

I was hoping to create the actual types with dynamic coding. On SolutionManager I'd find they are missing.
I definitely wouldn't drop any tests. Worst case scenario - I need to comment out the tests in SolutionManager...but at least I woudn't have to change any product code.