Comments (6)
Let's go for KEYWORD uppercase then.
I've
- converted the codebase,
- added to check to abaplint
- created an issue at abapGit to request similar exits for other types of code (local type, test class, etc.)
Thanks,
from abap-logger.
Agreed. As a maintainer, I would like to reach a consensus among contributors before settling on one rule. Could everyone state its preferred option ?
(Mine is all lowercase)
from abap-logger.
In general, I use keyword upper case. But any setting will do since I use an exit to auto pretty print the code:
https://gist.github.com/mbtools/71aa345a8ccb8f375568f9f337569154
from abap-logger.
While I would personally prefer lowercase, a large majority of the ABAP world uses keyword upper so I follow that trend.
Also see the Style Guides commentary on the topic.
https://github.com/SAP/styleguides/blob/main/clean-abap/sub-sections/UpperVsLowerCase.md
In general I would recommend keyword upper for OSS projects as that will be 'normal' to the majority. If a customer downloads something and makes a small edit for whatever local reasons and out of habit presses shift-f1 then it becomes difficult to pick up future deltas.
Also see same discussion on ABAP2XLSX
from abap-logger.
Thanks @mbtools for your exit. It's a game changer. I'll go for keyword uppercase for the repo (since the formatting is now automatic).
from abap-logger.
I also prefer uppercase keywords, probably because I am used to it.
Automatic pretty print before committing would be really nice.
from abap-logger.
Related Issues (20)
- Test classes use APPEND xxx TO yyy on sorted tables HOT 3
- bal_tt_msg type not exist HOT 1
- callback routine useless HOT 5
- adding syst messages no working for methods i,a,e,w,s of zcl_logger HOT 2
- Importance is not propagated when logging a table HOT 4
- Unit tests use non-existing SLG0 subobject HOT 5
- Limited Test Double Framework compatibility? HOT 2
- BAL-Log-Handle remains after destruction of ABAP-Logger HOT 1
- Misleading Name of Method popup() when providing custom Profile
- Build Hierarchy with Logger HOT 1
- Navigation to the application Log is not working for background jobs HOT 2
- Stale project? HOT 4
- Add support for BAPI_ALM_RETURN message structure HOT 1
- ABAP Logger v2 HOT 16
- Add injector class to match factory methods
- Add entry to log with context don't work if obj_to_log is an instance of a exception class
- Avoid abbreviations: add methods error, warning, info and success HOT 3
- Read messages from log with context HOT 4
- Option to use grid for DISPLAY_AS_POPUP HOT 1
- System message is logged if initial object is passed to as object to log HOT 3
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from abap-logger.