`#[primary_key(..)]` is not generated

[abbychau]

`#[primary_key(..)]` is not generated

[abbychau]

done

[Boscop]

Ah, I just saw that you only generate it when Identifiable is derived.
I think the inverse logic would be better:
When a table has primary key(s), append Identifiable to the list of derives!
Because the custom derives can only be specified to be the same for ALL tables, but not all tables might have primary keys..

[abbychau]

I am quite confused with this requirement.
On tables with primary keys are Identifiable .

and

The primary_key attribute is only applicable when deriving Identifiable.

[Boscop]

Yes, I mean, it would make sense to automatically add Identifiable to the list of derives when a table has a primary key! And then also automatically generate #[primary_key(..)].

Because the list of derives can only be specified to be the same for all tables but not all tables might have primary keys.

[abbychau]

Do you meant to add a flag so to automatically take the first field as the primary if no primary_key is provided?

[Boscop]

@abbychau No, I meant the primary key should be inferred from the table!{}. But I also mean that if a table has a primary key, Identifiable should be auto-added to the list of derives such that #[primary_key(..)] will be generated as well. (Not requiring the programmer to specify Identifiable in the list of custom derives, because it might not apply to all tables, since not all tables might have primary keys.)

[abbychau]

@abbychau No, I meant the primary key should be inferred from the table!{}. But I also mean that if a table has a primary key, Identifiable should be auto-added to the list of derives such that #[primary_key(..)] will be generated as well. (Not requiring the programmer to specify Identifiable in the list of custom derives, because it might not apply to all tables, since not all tables might have primary keys.)

How do you want it to be inferred? It can be in any name and may not be listed as the first field as well.

[Boscop]

@abbychau The same way it's inferred right now, when Identifiable is specified: The columns that constitute the primary key are listed in parens after the name of the table.

[abbychau]

oh, I missed the parens (eyes covered by ghosts) :p
It is workable. Thanks for the explanation.