Comments (13)
I'd like to take this up!
from bunk.
Alright! 🎉
from bunk.
Do I need to modify only the implementation in data/Cache.java or do I need to modify the method uses too?
from bunk.
You also need to change all the method calls.
Bonus: add unit tests for the new method.
from bunk.
You also need to change all the method calls.
Bonus: add unit tests for the new method.
Never added a unit test myself. Could you walk me through briefly, if you don't mind? 😃
from bunk.
Could I work on it at the night? if it's all good with you!
from bunk.
I fixed the build config issue. Update your fork accordingly. I also recommend using different branches for each pull request. See: https://guides.github.com/introduction/flow/
Never added a unit test myself. Could you walk me through briefly, if you don't mind? 😃
Actually, I haven't set up tests for Cache
yet. So you don't have to worry about that.
Here is an example unit test, for Subject
: SubjectTest.java
Could I work on it at the night? if it's all good with you!
Take your time!
from bunk.
Actually, I haven't set up tests for
Cache
yet. So you don't have to worry about that.
So I'd have to add tests for the entire 'Cache.java' if I'm not mistaken?
Here is an example unit test, for
Subject
: SubjectTest.java
Thank you!
Take your time!
Sure 😁
from bunk.
No, you don't have to add tests for Cache
.
from bunk.
Okay. Thank you!
from bunk.
No, you don't have to add tests for
Cache
.
So, all in all, I don't need to work with tests?
from bunk.
No. Just ensure that the app builds successfully without any warnings/errors.
from bunk.
Hi!
Is this issue taken by anyone?
Thanks! :)
from bunk.
Related Issues (18)
- Show login error message in pop up dialog. HOT 1
- Change member variable prefix in AttendanceActivity.java HOT 10
- Change member variable prefix in LoginActivity.java HOT 8
- Add proper Javadoc to all non-activity classes
- Update background color of the 'BUNK' button in LoginActivity, so that it is consistent with the theme colors HOT 3
- Add adaptive launcher icon HOT 10
- Add unit tests for Cache using Mockito
- Add unit tests for CookieJar using Mockito
- Add unit tests for IterApi using Mockito
- Add unit tests for Student
- Remove license text from top of source code HOT 3
- Implementation of Showpassword Option
- Add more unit tests for Subject model
- Backend HOT 1
- Password can be toggled to visible during waiting time.
- Users can access all locally saved passwords with the toggle password visibility button
- The server links have changed
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from bunk.