Giter Site home page Giter Site logo

Comments (3)

terrill avatar terrill commented on July 17, 2024

Resolved the border problem in CSS by removing borders from controller inputs and replacing them with outline properties on focus. Fixed in 78e6d1d

Resolved the black vs white PNG problem by checking for the user's computed background-color and converting the RGB value to grayscale. If it's < 128, it's a dark color, so use the white buttons. Otherwise use the black buttons. Fixed in a472c87

from ableplayer.

terrill avatar terrill commented on July 17, 2024

I'm reopening this issue for at least a couple of reasons:

  • Some high contrast modes make the borders around buttons prominent, which from my perspective result in a cluttered interface. Need to test this with high contrast users.
  • The volume slider is rendered invisible in some high contrast modes.

from ableplayer.

terrill avatar terrill commented on July 17, 2024

High contrast mode has been much-improved (tested using all Windows high contrast modes; Firefox color preferences; and Chrome using Google High Contrast Extension). Specifically:

  • Replaced all <button> elements with <div role="button"> on the controller. See #400 for more about this.
  • Removed outlines from the controller buttons.
  • Removed unnecessary borders and outlines from the overall design as these create a lot of clutter when presented in a high contrast foreground color, and their absence is barely noticeable in default contrast.
  • Synchronized the display styles of the volume slider and seekbar (the former was invisible in some high contrast modes; the latter was not).

from ableplayer.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.