Remove secondary confirmation in preferences dialog?

[coreystaten]

Remove secondary confirmation in preferences dialog?

[terrill]

I think we can do without. Users know what they changed, and after clicking Save I think "Done" provides sufficient confirmation.

[coreystaten]

Ah, I was actually asking about removing the whole "Done" dialog. As in, immediately after clicking save returning users to the main screen. Is there a need to have that dialog?

[terrill]

It's nice to get feedback. It doesn't have to be a dialog though - it could be a div with role="alert" that appears only temporarily then fades out. In that context though I think "Done" is a bit too cryptic - maybe it should say "Your settings have been saved."

[coreystaten]

In #69 this is now done with a popup div with role="alert". Closing.