Giter Site home page Giter Site logo

Comments (5)

sumitpai avatar sumitpai commented on May 26, 2024 1

Able to achieve MRRs close to table 4 in Rotate paper with multiclass loss. Need further benchmarking before merging.

from ampligraph.

rorymcgrath avatar rorymcgrath commented on May 26, 2024

In order to make 'generate_corrputions_for_fit' compliant my general understanding is that the following changes need to be made.

  1. Update the method signature to take an additional string argument corrupt_side which defaults to 's+o' which can take 3 values, 's' 'o' or 's+o'
  2. Add the following logic:
        if 's+o':
            we corrupt subjects and objects. This is the current behaviour
        if 'o':
            we corrupt objects only. Subjects are fixed
        if 's':
             we corrupt subject only. Objects are fixed.

Is this correct?

from ampligraph.

rorymcgrath avatar rorymcgrath commented on May 26, 2024

Support has been added to generate_corruptions_for_fit assuming the above logic is valid.

from ampligraph.

lukostaz avatar lukostaz commented on May 26, 2024

Has this been resolved and merged to dev?

from ampligraph.

sumitpai avatar sumitpai commented on May 26, 2024

Observation: Performance (MRR) better than nll/pairwise loss over FB15k but does not beat self_adversarial. This was tested with limited parameter combinations. Need extensive hyperparameter search to compare with self_adversarial.

from ampligraph.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.