Comments (4)
@stefanblaginov @sanketshevkar
Can I take up this issue?
from concerto-codegen.
Yep sure!
from concerto-codegen.
Since we already have the list of available reserved words, we can check if the current field is a part of the list or not. However, I have small doubt if we should check for these words without the $
symbol as well. For example, if $timestamp
is a reserved word then user obviously cannot use $timestamp
in the concerto file, but whether the user can use timestamp
field or not.
@sanketshevkar @dselman can you please confirm on this?
from concerto-codegen.
Since we already have the list of available reserved words, we can check if the current field is a part of the list or not. However, I have small doubt if we should check for these words without the
$
symbol as well. For example, if$timestamp
is a reserved word then user obviously cannot use$timestamp
in the concerto file, but whether the user can usetimestamp
field or not.
I believe $
is added so as to let users know its a reserved keyword. We would like to name our variables like $class
or __prototype__
(in JS), so that someone won't accidently use them. @dselman is that correct?
from concerto-codegen.
Related Issues (20)
- concerto-codegen supports import aliasing for [CSharp + Java]
- Add an option to ConcertoGraphVisistor to only add unidirectional vertices for supertype dependencies
- Bug: ConcertoGraphVisitor does not handle TypeReferece decorators
- CSharp code gen fails for model containing a concept Transaction
- Concerto error when inferring from a JSON Schema without a body
- Code Generator to bootstrap a vocab file
- Error when inferring from JSON Schema with alternations in body
- Various errors when inferring from JSON Schema
- Unable to compile CSharp code with models containing reserved keywords HOT 4
- TypeScript codegen creates invalid code for models with enums
- Mermaid diagram is incorrect
- Rollup fails to bundle module
- Inferring from JSON Schema may produce Concerto with properties starting with $
- Update all Concerto main repo dependencies to latest version
- [Enhancement] Create codegen featureset/delta documentation table HOT 1
- add a Accord Project Concerto Contribution Guide link with title in Readme file HOT 4
- Enhance graph.findConnectedGraph to use type hierarchy HOT 10
- Supporting Map type declaration, key and value for vocabulary codegen
- Vocabulary is auto generated for $identifier
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concerto-codegen.