Switch to Accord Project's Concerto (0.80)

[accordproject]

Switch to Accord Project's Concerto (0.80)

[mttrbrts]

This is sound IMO. The concerto module includes test coverage for the usual unstubbed case.

[jeromesimeon]

I'm suspecting the error is triggered by this line in the latest Concerto code:
https://github.com/accordproject/concerto/blob/ad309eaf207f8e57f219d30dd574970e694f2e77/lib/modelmanager.js#L641

[jeromesimeon]

The new Concerto code seems to make use of https://joshmiller.cc/symbol-hasinstance/

[jeromesimeon]

A slightly more specific analysis of what I think the problem is, and a proposed fix.

Why are tests failing:

1. the behaviour for instanceof in Concerto classes (e.g., for ModelManager) is overridden using the idiom here: https://github.com/accordproject/concerto/blob/ad309eaf207f8e57f219d30dd574970e694f2e77/lib/modelmanager.js#L641
   which means it relies on the presence of a _isModelManager field in the object instance.
2. sinon's createStubInstance method does not call the constructors which means _isModelManager is not initialised.
3. as a result tests relying on instanceof (e.g., visitors) will always return false

So I believe the support for instanceof should work as expected when using the library, but will fail in the mocked tests.

I could not find a very official way to mock the constructor through sinon in Stack overflow or in the Sinon documentation. However, the following does work:
Instead of:

let thing = sinon.createStubInstance(ModelManager);

in the tests, use:

let thing = sinon.createStubInstance(ModelManager);
thing._isModelManager = true;

Better suggestions to address this are welcome.

[jeromesimeon]

This is sound IMO. The concerto module includes test coverage for the usual unstubbed case.

Thanks so much for the quick feedback. Corresponding fixes are in PR #24