Comments (10)
Niladri24dutta
commented on September 23, 2024
@jeromesimeon created a PR to update the package name
from concerto.
jeromesimeon
commented on September 23, 2024
Thanks @Niladri24dutta ! That's great. I would love to get @mttrbrts 's feedback on this issue since he did the refactoring into a monorepo.
from concerto.
mttrbrts
commented on September 23, 2024
@jeromesimeon I've left some minor comments in the PR. otherwise it LGTM 👍
from concerto.
jeromesimeon
commented on September 23, 2024
@mttrbrts Great thanks! I wanted to make sure you agree with the issue in the first place!
from concerto.
jeromesimeon
commented on September 23, 2024
A few things that should be done for this:
- Make sure all references across packages use the new name. Most of them are in the
concerto-toolspackage. Here is a grep on my local copy:
bash-3.2$ grep -r require packages/*/lib | grep concerto | grep accordproject | grep -v '@accordproject/concerto-tools'
packages/concerto-cli/lib/commands.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-cli/lib/commands.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-cli/lib/commands.js:const DefaultModelFileLoader = require('@accordproject/concerto').DefaultModelFileLoader;
packages/concerto-cli/lib/commands.js:const FileWriter = require('@accordproject/concerto').FileWriter;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EventDeclaration = require('@accordproject/concerto').EventDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
- Review the READMEs/Dev instructions to make sure they refer to the new name if necessary.
- I am not entirely clear, but there might be some build scripts that also refer to the package (this could be checked later).
Once the tests pass, I'll keep an eye on the deployment to npm and can help with that if need be.
from concerto.
Niladri24dutta
commented on September 23, 2024
A few things that should be done for this:
* Make sure all references across packages use the new name. Most of them are in the `concerto-tools` package. Here is a grep on my local copy:bash-3.2$ grep -r require packages/*/lib | grep concerto | grep accordproject | grep -v '@accordproject/concerto-tools' packages/concerto-cli/lib/commands.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-cli/lib/commands.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-cli/lib/commands.js:const DefaultModelFileLoader = require('@accordproject/concerto').DefaultModelFileLoader; packages/concerto-cli/lib/commands.js:const FileWriter = require('@accordproject/concerto').FileWriter; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration; packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EventDeclaration = require('@accordproject/concerto').EventDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const Field = require('@accordproject/concerto').Field; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration; packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;* Review the READMEs/Dev instructions to make sure they refer to the new name if necessary. * I am not entirely clear, but there might be some build scripts that also refer to the package (this could be checked later).Once the tests pass, I'll keep an eye on the deployment to npm and can help with that if need be.
I have made the requested changes in the PR
from concerto.
jeromesimeon
commented on September 23, 2024
Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core
from concerto.
Niladri24dutta
commented on September 23, 2024
Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core
@jeromesimeon
Just a question in the installation of npm document above , do we need to update the commands which refers to@accordproject/concertoe.gnpm install @accordproject/concerto --save
from concerto.
jeromesimeon
commented on September 23, 2024
Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core
@jeromesimeon
Just a question in the installation of npm document above , do we need to update the commands which refers to@accordproject/concertoe.gnpm install @accordproject/concerto --save
I think this is already fixed actually. It's probably just npm getting a little confused since we haven't had a first release yet. If you look at the latest tagged "unstable" version you have:
https://www.npmjs.com/package/@accordproject/concerto-core/v/0.80.4-20191004042248
(or in the repo itself)
from concerto.
Niladri24dutta
commented on September 23, 2024
@jeromesimeon that makes sense now. is this PR elligible for hacktoberfest?
from concerto.
Related Issues (20)
- LocalDateTime
- Update CTO grammar for Import Aliasing HOT 2
- Update CTO printer for Import Aliasing
- Optimizations for applying decorators on a model HOT 1
- Vocabularies don't support namespace-scoped decorators HOT 1
- Update runtime classes to understand import aliasing
- Serialization exception when declaring a default false boolean field
- Update concerto-core/serializer to understand aliased imports HOT 2
- Update concerto-core/introspector to understand aliased imports
- Update concerto-analysis rules to analyse aliased imports HOT 3
- Multiple occurence of imported type in importTypes statement
- Redefining an imported type is allowed HOT 3
- Update v4 concerto
- DCS with namespace target, don't apply decorators on top of the namespace. HOT 5
- Update docs about import aliasing usage
- Update concerto-analyser to support import aliasing
- Document / Clarify naming rules for identifiers HOT 4
- concerto-codegen supports import aliasing for Java HOT 1
- Compression for serialized objects HOT 1
- API: getActualImportTypeName() in model Flle in aliasing
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from concerto.