Comments (8)
janriemer
commented on May 24, 2024
2
Isn't this PR adding support for ES6 with babel? Can it be merged?
from string-similarity.
balazsorban44
commented on May 24, 2024
1
From terser
Why choose terser?
uglify-es is no longer maintained and uglify-js does not support ES6+.
terser is a fork of uglify-es that retains API and CLI compatibility with uglify-es and uglify-js@3.
from string-similarity.
ljmerza
commented on May 24, 2024
1
es6 has been out for almost 5 years. why go through the trouble of supporting uglify-js? don't enable outdated code.
from string-similarity.
aceakash
commented on May 24, 2024
Don't know enough about Uglify, sorry. Does it support ES6? That might be the difference.
Try using the latest version 1.x of string-similarity which is ES5 to verify.
from string-similarity.
evgenyfadeev
commented on May 24, 2024
uglify does not support es6, so I thought you might add a build config to transpile the code to es5...
from string-similarity.
aceakash
commented on May 24, 2024
Fair enough @evgenyfadeev, I'm open to any PRs for build config.
from string-similarity.
janriemer
commented on May 24, 2024
@aceakash @evgenyfadeev
Actually, terser supports minification of ES6. 👌
I've used it with rollup in scrolldir-observable.
from string-similarity.
sitch
commented on May 24, 2024
bump
from string-similarity.
Related Issues (20)
- Strange/incorrect matching
- This is not the Dice coefficient HOT 1
- [HELP!!] Latest version does not detect spaces, and 2.0.0 version is not case sensitive.
- Error: Bad arguments: First argument should be a string, second should be an array of strings HOT 3
- Feature suggestion - pass array of objects as targets for findBestMatch function HOT 1
- compareTwoStrings with arguments length lower than 3 since HOT 1
- LICENSE.md and package.json disagree
- CommonJS causing optimization bailouts
- How is similarity calculated HOT 5
- Does not seem to care about the order of words HOT 2
- IE support HOT 3
- findBestMatch : accept a list of objects HOT 2
- compareTwoStrings return wrong output HOT 1
- Is it possible to import it in a ES6 module ? (front-side) HOT 1
- compareTwoStrings() not case insensitive as documentation suggest HOT 1
- Adding an optional param for replacing string and case sensitivity. HOT 3
- Support for ie10
- compareTwoStrings returning 1 for small and different strings HOT 1
- first.replace is not a function HOT 2
- Matching % seems incorrect HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from string-similarity.