Comments (10)
@aaronosb I did! Thanks for sharing the repo details. I've shared this with other folks and will update this issue once I have a fix or feedback.
from dependency-review-action.
+1 as I got affected by this issue too.
We try to use mikro-orm/migrations
, depending on umzug
, depending on rushstack
, depending on [email protected]
.
from dependency-review-action.
@aaronosb @paulz-swyftx The API is now returning the proper results, and I've confirmed that the action is behaving as expected. I've created these two example PRs:
- future-funk/bug-free-sniffle#8 -- has
[email protected]
, does not raise errors since the vulnerability was introduced at[email protected]
. - future-funk/bug-free-sniffle#9 -- has
[email protected]
which has an open vulnerability since.0.0.0
with no fixes. This check fails.
Closing this issue, thanks for your patience! Please re-open if needed.
from dependency-review-action.
Hi @aaronosb, thanks for the report. From the screenshot it looks like you should not be getting this warning indeed, do you see the same error if you view the rich diff of the PR for the package-lock.json change? (docs on how to do this)
from dependency-review-action.
I do not get the same warning/error using the rich diff
from dependency-review-action.
@aaronosb If this is for a public repo, can you post a link? If not, can you email me the username/organization name and repo name to my username at github.com?
from dependency-review-action.
It was a private repo I can shoot you the info over in an email
from dependency-review-action.
@febuiles did you get the email with repo details?
from dependency-review-action.
@aaronosb apologies for the lack of feedback on this. After reproducing the issue I noticed that it's caused by the API itself and not the action:
$ gh api -H "Accept: application/vnd.github+json" /repos/future-funk/bug-free-sniffle/dependency-graph/compare/main...add-colors
[
{
"change_type": "added",
"manifest": "package-lock.json",
"ecosystem": "npm",
"name": "colors",
"version": "1.0.3",
"package_url": "pkg:npm/[email protected]",
"license": "MIT",
"source_repository_url": "https://github.com/Marak/colors.js",
"vulnerabilities": [
{
"severity": "high",
"advisory_ghsa_id": "GHSA-gh88-3pxp-6fm8",
"advisory_summary": "Infinite Loop in colors.js",
"advisory_url": "https://github.com/advisories/GHSA-gh88-3pxp-6fm8"
}
]
},
{
"change_type": "added",
"manifest": "package.json",
"ecosystem": "npm",
"name": "colors",
"version": "1.0.3",
"package_url": "pkg:npm/[email protected]",
"license": "MIT",
"source_repository_url": "https://github.com/Marak/colors.js",
"vulnerabilities": [
{
"severity": "high",
"advisory_ghsa_id": "GHSA-gh88-3pxp-6fm8",
"advisory_summary": "Infinite Loop in colors.js",
"advisory_url": "https://github.com/advisories/GHSA-gh88-3pxp-6fm8"
}
]
}
]
Once the API fix is released I will close this issue.
from dependency-review-action.
Thank you for the speedy response @febuiles
from dependency-review-action.
Related Issues (20)
- [BUG] When the report exceeds 64KB pr issue is not created since it exceeds max comment issue HOT 1
- Why is this not named `dependency-review` HOT 1
- Job Summary Size Limitation aborts the job [BUG] HOT 10
- [BUG] Release 4.3.4 breaking change with SPDX expressions HOT 9
- [BUG] Action Is Now Unable To Parse NPM pURL Without a Namespace HOT 8
- [BUG] Listing too many allow-dependencies-licenses makes the summary output unreadable
- Duplicate
- Support for GHES
- Report of existing Branch
- Packages being flagged incorrectly with invalid SPDX license definitions HOT 6
- [BUG] `allow-dependencies-licenses` not respected after changing from `==` to `>=` with Python
- Print `Dependency Changes` in PR comment
- [BUG] Error "fetch failed" when using proxy HOT 2
- Add comment when warn-only: true and comment-summary-in-pr: on-failure HOT 6
- [BUG] unexpected addition of `AND NOASSERTION` to license when updating pywin32-ctypes HOT 2
- [BUG] Dependency Review gets stuck if forked . HOT 1
- Show patched version of dependency in the dependency review summary HOT 1
- [BUG] warn-only set and job fails when having a vulnerability
- Add option for commit status check
- Can it work with normal push instead of just pull request?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.