Comments (5)
Also experiencing this issue in some of my repos... looking forward to its resolution! =)
from dependency-review-action.
I'm finding this issue in testing this action, also. I tried importing a package with a proper license
entry in it's package.json as well as a LICENSE file but am getting this message and not seeing the expected failure from the action.
EDIT
Updating with some details. In order to test this, I added a package (https://github.com/joachimdalen/DevUI) that is listed as GPL-3.0 on npm and github.
- package.json includes
"license": "GPL-3.0"
which appears correctly formatted - https://github.com/joachimdalen/DevUI/blob/master/LICENSE appears correctly formatted
- The license appears to be recognized by Github and we can see the license as a
GPL-3.0 license
on the project homepage
I peeked under the covers at the github action and it is pulling the license from the github dependency-graph API
GET /repos/{owner}/{repo}/dependency-graph/compare/{baseRef}...{headRef}
For some packages, we're getting correct values (e.g.: dayjs
is getting correctly marked with the MIT
license). However, for this one the license is null
in the API response, which the action can't interpret (obviously). I think this actually needs to be filed with the github API.
{
"change_type": "added",
"manifest": "package-lock.json",
"ecosystem": "npm",
"name": "@joachimdalen/devui",
"version": "2.0.0-rc12",
"package_url": "pkg:npm/%40joachimdalen/[email protected]",
"license": null,
"source_repository_url": "https://github.com/joachimdalen/DevUI",
"scope": "runtime",
"vulnerabilities": []
},
from dependency-review-action.
@jcasner Thanks for diving into this, to add further details: The API only returns licenses for the top N licenses for any given repo (not sure if N is the same for all ecosystems). I'm thinking that the best way to proceed here is to call the GitHub licenses API endpoint if license :null
in the vulnerabilities payload, what do you think?
from dependency-review-action.
License detection was improved in the latest release of the Action by adding a fallback to GitHub's License API. Please re-open this issue if you're still experiencing problems.
from dependency-review-action.
I am encountering this issue, is there a workaround to prevent the tool from flagging itself? Thanks!
from dependency-review-action.
Related Issues (20)
- Bug: Some repos get error "fetch failed" when fetching v4.2.3 HOT 3
- Action fails to decorate PR when text is too long HOT 2
- Deny Packages Icon should be Red X (not a yellow warning) HOT 3
- Feature Request: Block on unknown licenses HOT 1
- `warn_only` Does Not Apply When Using a Deny List HOT 1
- error "fetch failed" with v4.2.5 HOT 3
- Scorecard table URLs include duplicate https:// HOT 3
- MIT is an invalid SPDX license identifier? HOT 2
- Question: Is this action limited to revisions on the _default_ branch only? HOT 2
- Conflict between vulnerabilities in scorecard vs check
- v4.3.0 Causing PURL Processing Errors HOT 6
- Allow this action to run on branch HOT 4
- Latest release breaks dependabot HOT 3
- Configuring allow-dependencies-licenses fails the action HOT 3
- Error :- Purl String argument is required . HOT 4
- Adding a license in 'allow-dependencies-licenses' does not prevent it from being populated in "invalid-license-changes" HOT 5
- Job Summary Size Limitation aborts the job HOT 1
- `fail-on-severity` should still show lower severity vulnerabilities
- [BUG] When the report exceeds 64KB pr issue is not created since it exceeds max comment issue HOT 1
- Why is this not named `dependency-review` HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.