Giter Site home page Giter Site logo

Comments (5)

RobPasMue avatar RobPasMue commented on June 25, 2024 2

Also experiencing this issue in some of my repos... looking forward to its resolution! =)

from dependency-review-action.

jcasner avatar jcasner commented on June 25, 2024 1

I'm finding this issue in testing this action, also. I tried importing a package with a proper license entry in it's package.json as well as a LICENSE file but am getting this message and not seeing the expected failure from the action.

EDIT
Updating with some details. In order to test this, I added a package (https://github.com/joachimdalen/DevUI) that is listed as GPL-3.0 on npm and github.

I peeked under the covers at the github action and it is pulling the license from the github dependency-graph API

GET /repos/{owner}/{repo}/dependency-graph/compare/{baseRef}...{headRef}

For some packages, we're getting correct values (e.g.: dayjs is getting correctly marked with the MIT license). However, for this one the license is null in the API response, which the action can't interpret (obviously). I think this actually needs to be filed with the github API.

  {
    "change_type": "added",
    "manifest": "package-lock.json",
    "ecosystem": "npm",
    "name": "@joachimdalen/devui",
    "version": "2.0.0-rc12",
    "package_url": "pkg:npm/%40joachimdalen/[email protected]",
    "license": null,
    "source_repository_url": "https://github.com/joachimdalen/DevUI",
    "scope": "runtime",
    "vulnerabilities": []
  },

from dependency-review-action.

febuiles avatar febuiles commented on June 25, 2024 1

@jcasner Thanks for diving into this, to add further details: The API only returns licenses for the top N licenses for any given repo (not sure if N is the same for all ecosystems). I'm thinking that the best way to proceed here is to call the GitHub licenses API endpoint if license :null in the vulnerabilities payload, what do you think?

from dependency-review-action.

febuiles avatar febuiles commented on June 25, 2024

License detection was improved in the latest release of the Action by adding a fallback to GitHub's License API. Please re-open this issue if you're still experiencing problems.

from dependency-review-action.

raphaeldeem-jsq avatar raphaeldeem-jsq commented on June 25, 2024

I am encountering this issue, is there a workaround to prevent the tool from flagging itself? Thanks!

from dependency-review-action.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.