Comments (7)
@wmmc88 Thanks for your input. Do you mind creating a new issue for your Cargo runs so the problem doesn't get lost in the comments here?
@febuiles created new issue to track: #672
from dependency-review-action.
More details about unknown licenses in #182 (comment)
from dependency-review-action.
@jcasner I'm currently working on improving the license support to get much more complete coverage of projects hosted in GitHub/supported by GitHub's Licenses API. Your second proposal sounds reasonable even with better license coverage, so I think we can do something about this soon.
The packages allowlist sounds like a "nice to have", but not mandatory in order to block PRs on null licenses. Is this a "someone could want" feature, or would it affect you if we only shipped what's outlined in your "Option 2"?
from dependency-review-action.
PR in progress here.
from dependency-review-action.
@jcasner we've improved license detection following the approach outlined above. We are also reporting unknown licenses in the output, I hope this helps. Closing this issue, please re-open if needed.
from dependency-review-action.
I think a flag to explicitly deny unknown licenses is still warranted.
The following run fails to be able to detect the license of anstyle:
https://github.com/wmmc88/windows-drivers-rs/actions/runs/7632001216/job/20791223328?pr=18
I am unsure why this is the case since the license is available here.
In any case, I still think there should be a wail to fail the job if unknown license is encountered. There are situations where you wont catch this in PR comments (ex. if triggered on push, or if triggered on PR from a fork)
from dependency-review-action.
@wmmc88 Thanks for your input. Do you mind creating a new issue for your Cargo runs so the problem doesn't get lost in the comments here?
from dependency-review-action.
Related Issues (20)
- [BUG] When the report exceeds 64KB pr issue is not created since it exceeds max comment issue HOT 1
- Why is this not named `dependency-review` HOT 1
- Job Summary Size Limitation aborts the job [BUG] HOT 10
- [BUG] Release 4.3.4 breaking change with SPDX expressions HOT 9
- [BUG] Action Is Now Unable To Parse NPM pURL Without a Namespace HOT 8
- [BUG] Listing too many allow-dependencies-licenses makes the summary output unreadable
- Duplicate
- Support for GHES
- Report of existing Branch
- Packages being flagged incorrectly with invalid SPDX license definitions HOT 6
- [BUG] `allow-dependencies-licenses` not respected after changing from `==` to `>=` with Python
- Print `Dependency Changes` in PR comment
- [BUG] Error "fetch failed" when using proxy HOT 2
- Add comment when warn-only: true and comment-summary-in-pr: on-failure HOT 6
- [BUG] unexpected addition of `AND NOASSERTION` to license when updating pywin32-ctypes HOT 2
- [BUG] Dependency Review gets stuck if forked . HOT 1
- Show patched version of dependency in the dependency review summary HOT 1
- [BUG] warn-only set and job fails when having a vulnerability
- Add option for commit status check
- Can it work with normal push instead of just pull request?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.