Comments (9)
Actually both PRs already contain documentation, 2.1.0 has been released with support for other event types!
If you see something behaving funny please open a new issue.
from dependency-review-action.
Thanks for the insight @Aaronkala! Maybe it'd make sense to add extra optional parameters to the Action so it accepts head/base revisions. Leaving this open while considering other options (PRs to mitigate this issue in the meantime are welcome!)
from dependency-review-action.
We would love to have this also. We we're trying to enable the github merge queue but due to the actions running on push
this wasn't possible.
The options we currently have are:
- Stop requiring the dependency-review action as a "needed check"
- Don't use merge queue
from dependency-review-action.
To me it looks like the head_ref
and base_ref
are only available on pull_request
or pull_request_target
events.
repo
and owner
should be available in all
From the docs: https://docs.github.com/en/actions/learn-github-actions/contexts#github-context
from dependency-review-action.
Thanks to the amazing work by @WillDaSilva the Action should now support event types different to "pull_request". You can test this by using the optional-refs
branch of this repo:
- name: 'Dependency Review'
uses: actions/dependency-review-action@optional-refs
with:
base-ref: ...
head-ref: ...
More info about defaults, and how to pass refs to other types of events in: https://github.com/actions/dependency-review-action/tree/optional-refs#configuration.
If no issues are found I'll cut a new release before the end of the week.
from dependency-review-action.
We have hundreds of repos using one reusable workflow with actions added centrally, and it's triggered by more event types like push
, schedule
, workflow_dispatch
, etc
from dependency-review-action.
workaround: if: github.event_name == 'pull_request'
from fastify/fastify#3884 (comment)
from dependency-review-action.
@PatMyron @Aaronkala Thanks for the report! Do these other event types support these fields?
dependency-review-action/src/main.ts
Lines 21 to 24 in 0e68684
If that's the case I think we can update the code to include them. I'm planning to start with workflow_dispatch
, what else would benefit from this?
from dependency-review-action.
hey 👋, just ran into this issue too, and push
event support is exactly what I'm looking for :)
from dependency-review-action.
Related Issues (20)
- [BUG] When the report exceeds 64KB pr issue is not created since it exceeds max comment issue HOT 1
- Why is this not named `dependency-review` HOT 1
- Job Summary Size Limitation aborts the job [BUG] HOT 10
- [BUG] Release 4.3.4 breaking change with SPDX expressions HOT 9
- [BUG] Action Is Now Unable To Parse NPM pURL Without a Namespace HOT 8
- [BUG] Listing too many allow-dependencies-licenses makes the summary output unreadable
- Duplicate
- Support for GHES
- Report of existing Branch
- Packages being flagged incorrectly with invalid SPDX license definitions HOT 6
- [BUG] `allow-dependencies-licenses` not respected after changing from `==` to `>=` with Python
- Print `Dependency Changes` in PR comment
- [BUG] Error "fetch failed" when using proxy HOT 2
- Add comment when warn-only: true and comment-summary-in-pr: on-failure HOT 6
- [BUG] unexpected addition of `AND NOASSERTION` to license when updating pywin32-ctypes HOT 2
- [BUG] Dependency Review gets stuck if forked . HOT 1
- Show patched version of dependency in the dependency review summary HOT 1
- [BUG] warn-only set and job fails when having a vulnerability
- Add option for commit status check
- Can it work with normal push instead of just pull request?
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. 📊📈🎉
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google ❤️ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from dependency-review-action.