Giter Site home page Giter Site logo

Comments (5)

panticmilos avatar panticmilos commented on July 26, 2024 1

hi @dfandrich, thank you for the report, we will take a look at it.

from labeler.

akutz avatar akutz commented on July 26, 2024

Mentioned in vmware-tanzu/vm-operator#50 (review) (this was not added automatically for some reason)

from labeler.

jw-maynard avatar jw-maynard commented on July 26, 2024

@panticmilos and @MaksimZhukov I'm working on a PR for this in my personal fork right now but I currently have a breaking change with the way the config is written. I basically put the existing config under a top level section name labels and added a new optional section called sizes.

Obviously there are other options for handling this:

  • a separate config file in the .github dir
  • an additional optional input to the action
  • some code to check if there is a labels top level item in the config and if not, fall back to the previous parsing

Do you guys have a preference?

jw-maynard#2

from labeler.

jw-maynard avatar jw-maynard commented on July 26, 2024

@panticmilos and @MaksimZhukov I'm working on a PR for this in my personal fork right now but I currently have a breaking change with the way the config is written. I basically put the existing config under a top level section name labels and added a new optional section called sizes.

Obviously there are other options for handling this:

  • a separate config file in the .github dir
  • an additional optional input to the action
  • some code to check if there is a labels top level item in the config and if not, fall back to the previous parsing

Do you guys have a preference?

jw-maynard#2

So I just noticed there is a v5 WIP with breaking changes in it so maybe I'll just work off of that branch

from labeler.

lucacome avatar lucacome commented on July 26, 2024

Any chance we can get some traction on this @MaksimZhukov ? 🙏

from labeler.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.