Comments (4)
Hello @alexandre-combemorel!
Yes, you are right, as described in the README ALL listed globs in any
selector have to match against ANY changed path. The following configuration
home:
- apps/home/*
- apps/home/**/*
- apps/middleware/*
- apps/middleware/**/*
is not equivalent to
home:
- any: ["apps/home/*", "apps/home/**/*", "apps/middleware/*", "apps/middleware/**/*"]
It is equivalent to
home:
- any: ['apps/home/*']
- any: ['apps/home/**/*']
- any: ['apps/middleware/*']
- any: ['apps/middleware/**/*']
If you want to apply a label if one of listed paths matches, you should use the config structure that you attached in the issue description. Does it make sense to you?
from labeler.
Hello @alexandre-combemorel
Thank you for bringing our attention to this issue. We will investigate it and come back to you as soon as we have some news π
from labeler.
Hi @marko-zivic-93, should I open a PR with the fix I suggested?
from labeler.
Sorry for the very late response, Ok I understand now, I got confused in the README as the example stands on 1 path only and it shows equivalent configuration.
It might be worth to add a second path to give more context?
But thank you for pointing out, it seems our CI is working correctly now.
from labeler.
Related Issues (20)
- Getting `sync-labels` type error after update to 5 version. HOT 4
- Create dynamic labels from branch name HOT 1
- any-glob-all-files does not working intuitevely HOT 4
- Sync-labels should not remove an unspecified label HOT 2
- Error when configuration is invalid HOT 1
- Branch name checks ignored as top level key HOT 2
- example fails yaml validation HOT 7
- Char HOT 1
- Node 16 gets warning HOT 2
- Description seems dangerous HOT 5
- Labeler should never remove labels it has not configured HOT 5
- Add a label to the PR if the review has ended with a request to make changes HOT 1
- Could not find pull request warning for pull_request closed event HOT 2
- Is it possible to label based on number of lines changed? HOT 1
- Update documentation to note that you can use sentences in labels HOT 1
- Allow for only applying a label if another label has not been applied (enumerated labels) HOT 1
- Merging `main` into PR causes incorrect labeling HOT 2
- Apply label only if it's the only change to the document HOT 1
- Hoy por mi maΓ±ana por ti HOT 1
- Very slow when many files match filter HOT 1
Recommend Projects
-
React
A declarative, efficient, and flexible JavaScript library for building user interfaces.
-
Vue.js
π Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.
-
Typescript
TypeScript is a superset of JavaScript that compiles to clean JavaScript output.
-
TensorFlow
An Open Source Machine Learning Framework for Everyone
-
Django
The Web framework for perfectionists with deadlines.
-
Laravel
A PHP framework for web artisans
-
D3
Bring data to life with SVG, Canvas and HTML. πππ
-
Recommend Topics
-
javascript
JavaScript (JS) is a lightweight interpreted programming language with first-class functions.
-
web
Some thing interesting about web. New door for the world.
-
server
A server is a program made to process requests and deliver data to clients.
-
Machine learning
Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.
-
Visualization
Some thing interesting about visualization, use data art
-
Game
Some thing interesting about game, make everyone happy.
Recommend Org
-
Facebook
We are working to build community through open source technology. NB: members must have two-factor auth.
-
Microsoft
Open source projects and samples from Microsoft.
-
Google
Google β€οΈ Open Source for everyone.
-
Alibaba
Alibaba Open Source for everyone
-
D3
Data-Driven Documents codes.
-
Tencent
China tencent open source team.
from labeler.