Giter Site home page Giter Site logo

Comments (8)

shamil-mubarakshin avatar shamil-mubarakshin commented on September 12, 2024 1

Its 8.4.0 when run from pwsh and 8.8.0 when run from bash

from runner-images.

kzantow avatar kzantow commented on September 12, 2024

This is also affecting https://github.com/anchore/sbom-action

from runner-images.

fasmat avatar fasmat commented on September 12, 2024

Quick update: the reason for the 000 status code seems to be the fact that the file is downloaded to a temporary file created with mktemp:

# this prints 000
tmp=$(mktemp)
curl -w '%{http_code}' -sL -H 'Accept:application/json' -o "$tmp" https://github.com/golangci/golangci-lint/releases/v1.57.0 

# this prints 200
curl -w '%{http_code}' -sL -H 'Accept:application/json' -o test.json https://github.com/golangci/golangci-lint/releases/v1.57.0

I'm not fully understanding why id did work on the previous version and not this one though 🤷

from runner-images.

shamil-mubarakshin avatar shamil-mubarakshin commented on September 12, 2024

Hey @fasmat, There seems to be a bug in curl v8.8.0 (which is shipped with git-for-windows v2.45.2) when used with --write-output. It is discussed in curl/curl#13845 and will probably make it to their next release

from runner-images.

fasmat avatar fasmat commented on September 12, 2024

Thanks for the response @shamil-mubarakshin

I hope that's the issue that we are experiencing. The curl version on the runner seems to be a different version:

curl --version
curl 8.4.0 (Windows) libcurl/8.4.0 Schannel WinIDN

But the observed issue seems to be the same 🤔

from runner-images.

ijunaidm avatar ijunaidm commented on September 12, 2024

@fasmat - Issue is with curl , lets wait and get the curl issue curl/curl#13845 gets fixed . Hence I am closing this issue.

from runner-images.

fasmat avatar fasmat commented on September 12, 2024

Is there any way to roll back the git that is installed on the runners? not only does it break curl it also causes regular issues with checking out our repository when building our source:

https://github.com/spacemeshos/go-spacemesh/actions/runs/9577708148/job/26406459251?pr=6049

These are recent issues that we didn't have a few weeks ago.

from runner-images.

kzantow avatar kzantow commented on September 12, 2024

Out of curiosity, why was this issue closed? The issue is in curl, but it's in a version of curl that is currently in the windows runners. Here is a workflow exhibiting the issue with curl 8.8.0 and showing that the older version, 8.7.1 does not have the problem: https://github.com/kzantow-anchore/sbom-action-test/actions/runs/9860639787/job/27227290279
Note that the default curl fails.

    runs-on: windows-latest
    steps:
      - run: sh -c 'curl -sSfL https://raw.githubusercontent.com/anchore/syft/main/install.sh > $(pwd)/install.sh'
      - run: |
          md curl
          curl https://curl.se/windows/dl-8.7.1_3/curl-8.7.1_3-win64-mingw.zip > curl/curl.zip
          cd curl
          unzip curl.zip
      - run: sh -c 'PATH="$(pwd)/curl/curl-8.7.1_3-win64-mingw/bin:$PATH" curl --version'
      - run: sh -c 'PATH="$(pwd)/curl/curl-8.7.1_3-win64-mingw/bin:$PATH" sh $(pwd)/install.sh -b curl-8.7.1'
      - run: sh -c 'curl-8.7.1/syft version'

      - run: sh -c 'curl --version'
      - run: sh -c 'sh $(pwd)/install.sh -b curl-8.8.0'
      - run: sh -c 'curl-8.8.0/syft version'

from runner-images.

Related Issues (20)

Recommend Projects

  • React photo React

    A declarative, efficient, and flexible JavaScript library for building user interfaces.

  • Vue.js photo Vue.js

    🖖 Vue.js is a progressive, incrementally-adoptable JavaScript framework for building UI on the web.

  • Typescript photo Typescript

    TypeScript is a superset of JavaScript that compiles to clean JavaScript output.

  • TensorFlow photo TensorFlow

    An Open Source Machine Learning Framework for Everyone

  • Django photo Django

    The Web framework for perfectionists with deadlines.

  • D3 photo D3

    Bring data to life with SVG, Canvas and HTML. 📊📈🎉

Recommend Topics

  • javascript

    JavaScript (JS) is a lightweight interpreted programming language with first-class functions.

  • web

    Some thing interesting about web. New door for the world.

  • server

    A server is a program made to process requests and deliver data to clients.

  • Machine learning

    Machine learning is a way of modeling and interpreting data that allows a piece of software to respond intelligently.

  • Game

    Some thing interesting about game, make everyone happy.

Recommend Org

  • Facebook photo Facebook

    We are working to build community through open source technology. NB: members must have two-factor auth.

  • Microsoft photo Microsoft

    Open source projects and samples from Microsoft.

  • Google photo Google

    Google ❤️ Open Source for everyone.

  • D3 photo D3

    Data-Driven Documents codes.