MSVC: header format errors when using catch2 since toolset updates

[gracicot]

MSVC: header format errors when using catch2 since toolset updates

[hemanthmanga]

@Costallat,
we have changed as mentioned in the below and got passed with your branch dev-5.x.y, Please try with change.

        uses: lukka/run-vcpkg@v11
        with:
          # Location of the vcpkg as submodule of the repository.
          vcpkgDirectory: '${{ github.workspace }}/vcpkg'
          useVcpkgToolchainFile: true
          vcpkgGitCommitId: '01f602195983451bc83e72f4214af2cbc495aa94'
          appendedCacheKey: ${{ hashFiles( '**/vcpkg.json' ) }}

[hemanthmanga]

@gracicot We are looking into the issue, we will get back to you after investigating this issue, Thanks.

[hemanthmanga]

@gracicot
The image deployment has completed, could you please try to rerun the workflow.

Image: windows-2022 Version: 20240610.1.0 Included Software: https://github.com/actions/runner-images/blob/win22/20240610.1/images/windows/Windows2022-Readme.md Image Release: https://github.com/actions/runner-images/releases/tag/win22%2F202406[10](https://github.com/hemanthmanga/kangaru/actions/runs/9514507006/job/26226851495#step:1:11).1

If you have any issues, please reach out to us.

[hemanthmanga]

@gracicot

In my dev-5.x.y branch where I use a modern setup, the problem is still happening. Here's a workflow run I tried today, with the 20240610.1.0 image: https://github.com/gracicot/kangaru/actions/runs/9360750011/job/26315233901#step:6:435

--- As of now 20240610.1.0 is the latest image version and we have ran the dev-5.x.y with workflow it got succeeded.

If you have any issues, Please reach to us, Thanks.

[Costallat]

Hi @hemanthmanga ,

Thanks for the information. I tested here and it worked. In fact we had to just update the vcpkgGitCommitId.

Thanks for the help!

[gracicot]

@hemanthmanga thank you! That was very informative. It fixed my pipeline too.

[Costallat]

I Have the same problem, if I don't force it to use MSVC 14.29 it uses an older version and the compiler complains that we need a newer one, so I forced it to use the 14.29.x, but it throws the same error from this ticket.

Tried to run today: https://github.com/mehah/otclient/actions/runs/9523710124/job/26314061584

---

If it helps this was the last build that worked:

https://github.com/mehah/otclient/actions/runs/9357386021/job/25756983650

The next one started to failed and you can see that there was no changes on the build(from our side):

https://github.com/mehah/otclient/actions/runs/9404759907

[gracicot]

@hemanthmanga The issue was not resolved.

On my master branch, the run you linked in your latest comment is very old and compile strictly in C++11 and C++14 so the problem don't appear, even if you upgrade the compiler.

In my dev-5.x.y branch where I use a modern setup, the problem is still happening. Here's a workflow run I tried today, with the 20240610.1.0 image: https://github.com/gracicot/kangaru/actions/runs/9360750011/job/26315233901#step:6:435

The problem happen in the header <format>, so C++20 needs to be enabled, which the dev-5.x.y uses.

---

EDIT: I also confirm the projects, compilation, test and external libraries installed with vcpkg work on a windows VM, so the problem must be in the image. The format header also works when including and using.

[gracicot]

@hemanthmanga I'm not sure how to say this. Your screenshot clearly shows my workflow in my master branch. You can see clearly that this workflow doesn't run visual studio 2022.

The windows 2019 and 2017 don't have that issue, since it's a problem with very recent MSVC version. Those images don't support C++20, and the problem only manifest in the format header, which is C++20 and up only.

My workflow still fails, I just re-ran it with the version you specified.

As you can see, the name of the tasks are different from what you ran.

Here's a link to the still failing workflow. https://github.com/gracicot/kangaru/actions/runs/9360750011/job/26465999363#step:6:510

Would creating a minimal repo with only one branch and only one task help identifying the issue?

[Costallat]

Can someone reopen this ticket? It was closed but it was tested on the wrong branch, I still have this issue also!

Tks!