Create duplicate record entry after update

[pisaruk]

Create duplicate record entry after update

[zilkey]

Thanks for using ActiveHash, and for taking the time to report the issue. I can't think of a reason why you would need to call save on an activehash object that's already been saved. Only one copy of that object will exist in memory, so just updating an attribute should be sufficient.

I agree that having save blow up on a record that is already part of the collection. It seems like we have a few ways to fix this:

• raise an error that's more specific, like "There's no need to save an object that already has an id"
• implement a save method that is a no-op if you call it on an object with an id

Which one seems like the better option to you?

[pisaruk]

I think that having a no-op save method and displaying the warning "There's no need to save an object that already has an id" would be the best approach.
What do you think?

[zilkey]

I think I prefer the no-op on its own, no logging (just so we don't fill up logs unnecessarily).

I'll add that today.

[zilkey]

Just pushed version 1.0.0 that has a no-op save for existing objects, and also adds the exists? method on the class.

Thanks again

[pisaruk]

Nice. Thank you.